NEW38218
webkit-patch upload --no-review should imply --no-obsolete 
https://bugs.webkit.org/show_bug.cgi?id=38218
Summary webkit-patch upload --no-review should imply --no-obsolete
Ojan Vafai
Reported 2010-04-27 14:09:33 PDT
If you are putting a patch up for non-review, it's unlikely that you want it to obsolete previous patches you've put up for review. It just removed an r+ from a reviewed patch because I uploaded a different patch with --no-review.
Attachments
Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2010-04-27 14:12:24 PDT
I see the flags as unrelated. However I can certainly see this use case. So long as you update the help I'd be OK with it.
Eric Seidel (no email)
Comment 2 2010-04-27 14:14:54 PDT
We you uploading a new patch to have it landed via the commit queue? That case is already supported by "land-safely" explicitly.
Adam Barth
Comment 3 2010-04-27 14:18:10 PDT
We should show land-safely in the main help.
Ojan Vafai
Comment 4 2010-04-27 15:11:48 PDT
(In reply to comment #2) > We you uploading a new patch to have it landed via the commit queue? > That case is already supported by "land-safely" explicitly. No. I was uploading a new patch that I committed without review. I would use post, but I wanted prepare-ChangeLog to be called with the right arguments, and incidentally, to get the other benefits of upload (check-webkit-style, etc).
Ojan Vafai
Comment 5 2010-04-27 15:20:44 PDT
FWIW, I don't feel too strongly about this. I was just surprised that non-review patches would also obsolete.
Note You need to log in before you can comment on or make changes to this bug.