Bug 38210 - Remove copy/paste addEventListener "custom" bindings via code generation
: Remove copy/paste addEventListener "custom" bindings via code generation
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: New Bugs
: 528+ (Nightly build)
: Other Mac OS X 10.5
: P2 Normal
Assigned To: Nobody
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-04-27 12:13 PDT by Adam Barth
Modified: 2010-04-27 14:24 PDT (History)
4 users (show)

See Also:


Attachments
Patch (54.04 KB, patch)
2010-04-27 12:16 PDT, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-04-27 12:13:59 PDT
Remove copy/paste addEventListener "custom" bindings via code generation
Comment 1 Adam Barth 2010-04-27 12:16:59 PDT
Created attachment 54442 [details]
Patch
Comment 2 Adam Barth 2010-04-27 12:17:29 PDT
Note that most of the change to CodeGeneratorJS.pm is just indenting existing code.
Comment 3 Darin Adler 2010-04-27 12:19:09 PDT
Comment on attachment 54442 [details]
Patch

Special cases in the code generator are OK; we can certainly live with them and keep refactoring and improving over time. But you could trigger them with special keywords instead of hard-coding function names if you prefer.
Comment 4 Adam Barth 2010-04-27 13:26:25 PDT
Comment on attachment 54442 [details]
Patch

Clearing flags on attachment: 54442

Committed r58330: <http://trac.webkit.org/changeset/58330>
Comment 5 Adam Barth 2010-04-27 13:26:31 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 WebKit Review Bot 2010-04-27 13:51:04 PDT
http://trac.webkit.org/changeset/58330 might have broken Qt Linux Release
The following changes are on the blame list:
http://trac.webkit.org/changeset/58329
http://trac.webkit.org/changeset/58330
http://trac.webkit.org/changeset/58331