Bug 38210 - Remove copy/paste addEventListener "custom" bindings via code generation
: Remove copy/paste addEventListener "custom" bindings via code generation
Status: RESOLVED FIXED
: WebKit
New Bugs
: 528+ (Nightly build)
: Other Mac OS X 10.5
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2010-04-27 12:13 PST by
Modified: 2010-04-27 14:24 PST (History)


Attachments
Patch (54.04 KB, patch)
2010-04-27 12:16 PST, Adam Barth
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2010-04-27 12:13:59 PST
Remove copy/paste addEventListener "custom" bindings via code generation
------- Comment #1 From 2010-04-27 12:16:59 PST -------
Created an attachment (id=54442) [details]
Patch
------- Comment #2 From 2010-04-27 12:17:29 PST -------
Note that most of the change to CodeGeneratorJS.pm is just indenting existing code.
------- Comment #3 From 2010-04-27 12:19:09 PST -------
(From update of attachment 54442 [details])
Special cases in the code generator are OK; we can certainly live with them and keep refactoring and improving over time. But you could trigger them with special keywords instead of hard-coding function names if you prefer.
------- Comment #4 From 2010-04-27 13:26:25 PST -------
(From update of attachment 54442 [details])
Clearing flags on attachment: 54442

Committed r58330: <http://trac.webkit.org/changeset/58330>
------- Comment #5 From 2010-04-27 13:26:31 PST -------
All reviewed patches have been landed.  Closing bug.
------- Comment #6 From 2010-04-27 13:51:04 PST -------
http://trac.webkit.org/changeset/58330 might have broken Qt Linux Release
The following changes are on the blame list:
http://trac.webkit.org/changeset/58329
http://trac.webkit.org/changeset/58330
http://trac.webkit.org/changeset/58331