RESOLVED FIXED Bug 38210
Remove copy/paste addEventListener "custom" bindings via code generation 
https://bugs.webkit.org/show_bug.cgi?id=38210
Summary Remove copy/paste addEventListener "custom" bindings via code generation
Adam Barth
Reported 2010-04-27 12:13:59 PDT
Remove copy/paste addEventListener "custom" bindings via code generation
Attachments
Patch (54.04 KB, patch)
2010-04-27 12:16 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-04-27 12:16:59 PDT
Created attachment 54442 [details] Patch
Adam Barth
Comment 2 2010-04-27 12:17:29 PDT
Note that most of the change to CodeGeneratorJS.pm is just indenting existing code.
Darin Adler
Comment 3 2010-04-27 12:19:09 PDT
Comment on attachment 54442 [details] Patch Special cases in the code generator are OK; we can certainly live with them and keep refactoring and improving over time. But you could trigger them with special keywords instead of hard-coding function names if you prefer.
Adam Barth
Comment 4 2010-04-27 13:26:25 PDT
Comment on attachment 54442 [details] Patch Clearing flags on attachment: 54442 Committed r58330: <http://trac.webkit.org/changeset/58330>
Adam Barth
Comment 5 2010-04-27 13:26:31 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 6 2010-04-27 13:51:04 PDT
http://trac.webkit.org/changeset/58330 might have broken Qt Linux Release The following changes are on the blame list: http://trac.webkit.org/changeset/58329 http://trac.webkit.org/changeset/58330 http://trac.webkit.org/changeset/58331
Note You need to log in before you can comment on or make changes to this bug.