Bug 3821 - GW: add KWQWMatrix white-room implementation
Summary: GW: add KWQWMatrix white-room implementation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P4 Enhancement
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks: 3250
  Show dependency treegraph
 
Reported: 2005-07-02 18:47 PDT by Eric Seidel (no email)
Modified: 2005-07-05 01:39 PDT (History)
0 users

See Also:


Attachments
adds a real qwmatrix implementation, and removes stub from KWQPixmap.h (7.68 KB, patch)
2005-07-02 20:04 PDT, Eric Seidel (no email)
mjs: review-
Details | Formatted Diff | Diff
Fixes the two issues mjs raised (7.96 KB, patch)
2005-07-03 15:09 PDT, Eric Seidel (no email)
mjs: review+
Details | Formatted Diff | Diff
project file diff (1.78 KB, patch)
2005-07-05 00:33 PDT, Eric Seidel (no email)
mjs: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2005-07-02 18:47:02 PDT
Attached is my white-room implementation of KWQWMatrix.  It's very simple and uses CGAffineTransform 
for everything.  But it's enough to get other projects up and running correctly on KWQ.
Comment 1 Eric Seidel (no email) 2005-07-02 20:04:01 PDT
Created attachment 2761 [details]
adds a real qwmatrix implementation, and removes stub from KWQPixmap.h
Comment 2 Maciej Stachowiak 2005-07-03 03:47:44 PDT
Comment on attachment 2761 [details]
adds a real qwmatrix implementation, and removes stub from KWQPixmap.h

Seems like both your comments here are right. QWMatrix indeed takes degrees
while CGAffineTransform takes radians. And the behavior of invert() on a
singular matrix would not match between Qt and CG.
Comment 3 Eric Seidel (no email) 2005-07-03 15:09:12 PDT
Created attachment 2776 [details]
Fixes the two issues mjs raised
Comment 4 Eric Seidel (no email) 2005-07-05 00:33:49 PDT
Created attachment 2801 [details]
project file diff
Comment 5 Maciej Stachowiak 2005-07-05 01:39:27 PDT
Comment on attachment 2801 [details]
project file diff

r=me assuming you tested