WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
38209
commands/steps should use a tighter mock for options
https://bugs.webkit.org/show_bug.cgi?id=38209
Summary
commands/steps should use a tighter mock for options
Ojan Vafai
Reported
2010-04-27 11:42:47 PDT
[11:39am] abarth: the real issue [11:39am] abarth: is that we use a very loose mock for options [11:39am] abarth: the right thing to do [11:39am] abarth: is to use a much tighter mock [11:39am] abarth: that's an easy change [11:40am] abarth: in commandtest.py [11:40am] abarth: options=Mock() [11:40am] abarth: which means we assume that every option can be read [11:40am] abarth: when running the command [11:40am] abarth: instead [11:40am] abarth: we should compute which options will actually exist [11:40am] abarth: from the |command|
Attachments
Add attachment
proposed patch, testcase, etc.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug