Bug 38209 - commands/steps should use a tighter mock for options
Summary: commands/steps should use a tighter mock for options
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-27 11:42 PDT by Ojan Vafai
Modified: 2010-04-27 11:42 PDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2010-04-27 11:42:47 PDT
[11:39am] abarth: the real issue
[11:39am] abarth: is that we use a very loose mock for options
[11:39am] abarth: the right thing to do
[11:39am] abarth: is to use a much tighter mock
[11:39am] abarth: that's an easy change
[11:40am] abarth: in commandtest.py
[11:40am] abarth: options=Mock()
[11:40am] abarth: which means we assume that every option can be read
[11:40am] abarth: when running the command
[11:40am] abarth: instead
[11:40am] abarth: we should compute which options will actually exist
[11:40am] abarth: from the |command|