Bug 38207 - [V8] Handle OR ('|') conditional in action_derivedsourcesallinone.py
Summary: [V8] Handle OR ('|') conditional in action_derivedsourcesallinone.py
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-27 11:32 PDT by Kinuko Yasuda
Modified: 2010-04-27 16:24 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.46 KB, patch)
2010-04-27 11:56 PDT, Kinuko Yasuda
no flags Details | Formatted Diff | Diff
Patch (2.06 KB, patch)
2010-04-27 11:59 PDT, Kinuko Yasuda
jianli: review+
jianli: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kinuko Yasuda 2010-04-27 11:32:10 PDT
Recently we introduced '|' as OR conditional (like '&' for AND) and v8's DerivedSources generation also needs to support it.
See bug 37998 for details.
Comment 1 Kinuko Yasuda 2010-04-27 11:56:25 PDT
Created attachment 54438 [details]
Patch
Comment 2 Kinuko Yasuda 2010-04-27 11:59:12 PDT
Created attachment 54439 [details]
Patch
Comment 3 Kinuko Yasuda 2010-04-27 12:02:21 PDT
The proposed patch worked for me in my chromium build with FileError.idl, that has OR '|' in its definition.
Comment 4 Yaar Schnitman 2010-04-27 14:28:46 PDT
LGTM though I'm not a reviewer.
Comment 5 Jian Li 2010-04-27 14:42:01 PDT
Comment on attachment 54439 [details]
Patch

r=me

Please land with the following fix.

WebCore/WebCore.gyp/scripts/action_derivedsourcesallinone.py:85
 +  # Wraps conditional with ENABLE() and && if more than one conditional is specified.
Please update the comment.
Comment 6 Kinuko Yasuda 2010-04-27 16:24:35 PDT
Committed r58352: <http://trac.webkit.org/changeset/58352>