FrameView::forceLayout() is just calling layout(). It seems we can just get rid of the function and call layout directly.
Created attachment 54415 [details] Remove forceLayout I did not commented on the changelog of each port, the change seems simple enough.
Comment on attachment 54415 [details] Remove forceLayout I think there's semantic value in forceLayout(), and useful history in the comment in FrameView::forceLayout() that you are removing. I suggest leaving things as they are.
Personally it has just confused me and it doesn't actually *force* the layout.
(In reply to comment #2) > (From update of attachment 54415 [details]) > I think there's semantic value in forceLayout(), and useful history in the > comment in FrameView::forceLayout() that you are removing. Doesn't it just add complexity? A newcomer, let say me ;), would assume that forceLayout() always relayout the render tree.
Created attachment 54686 [details] Patch for Qt only Remove forceLayout() use in Qt, replace them by layout(). I did not changed one in QWebPage because it is gonna disappear altogether thanks to https://bugs.webkit.org/show_bug.cgi?id=38179
Comment on attachment 54686 [details] Patch for Qt only I support this change!
Comment on attachment 54686 [details] Patch for Qt only Rejecting patch 54686 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Kenneth Rohde Christiansen', u'--force']" exit_code: 1 Parsed 4 diffs from patch file(s). patching file WebKit/qt/Api/qwebpage.cpp Hunk #1 FAILED at 127. Hunk #2 succeeded at 2104 (offset 4 lines). 1 out of 2 hunks FAILED -- saving rejects to file WebKit/qt/Api/qwebpage.cpp.rej patching file WebKit/qt/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp Hunk #1 succeeded at 347 (offset 5 lines). patching file WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp Full output: http://webkit-commit-queue.appspot.com/results/1851187
Created attachment 54706 [details] Patch for Qt only Luiz was faster than me to patch QWebPage :) Same patch updated without conflict.
Comment on attachment 54706 [details] Patch for Qt only Clearing flags on attachment: 54706 Committed r58523: <http://trac.webkit.org/changeset/58523>
All reviewed patches have been landed. Closing bug.