Bug 38199 - Get rid of forceLayout() on FrameView
Summary: Get rid of forceLayout() on FrameView
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-27 07:30 PDT by Benjamin Poulain
Modified: 2010-04-29 10:35 PDT (History)
6 users (show)

See Also:


Attachments
Remove forceLayout (13.61 KB, patch)
2010-04-27 07:36 PDT, Benjamin Poulain
simon.fraser: review-
simon.fraser: commit-queue-
Details | Formatted Diff | Diff
Patch for Qt only (3.04 KB, patch)
2010-04-29 02:40 PDT, Benjamin Poulain
kenneth: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
Patch for Qt only (3.09 KB, patch)
2010-04-29 07:39 PDT, Benjamin Poulain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2010-04-27 07:30:05 PDT
FrameView::forceLayout() is just calling layout(). It seems we can just get rid of the function and call layout directly.
Comment 1 Benjamin Poulain 2010-04-27 07:36:24 PDT
Created attachment 54415 [details]
Remove forceLayout

I did not commented on the changelog of each port, the change seems simple enough.
Comment 2 Simon Fraser (smfr) 2010-04-27 08:39:00 PDT
Comment on attachment 54415 [details]
Remove forceLayout

I think there's semantic value in forceLayout(), and useful history in the comment in FrameView::forceLayout() that you are removing.

I suggest leaving things as they are.
Comment 3 Kenneth Rohde Christiansen 2010-04-27 08:46:27 PDT
Personally it has just confused me and it doesn't actually *force* the layout.
Comment 4 Benjamin Poulain 2010-04-27 08:47:14 PDT
(In reply to comment #2)
> (From update of attachment 54415 [details])
> I think there's semantic value in forceLayout(), and useful history in the
> comment in FrameView::forceLayout() that you are removing.

Doesn't it just add complexity?
A newcomer, let say me ;), would assume that forceLayout() always relayout the render tree.
Comment 5 Benjamin Poulain 2010-04-29 02:40:02 PDT
Created attachment 54686 [details]
Patch for Qt only

Remove forceLayout() use in Qt, replace them by layout().

I did not changed one in QWebPage because it is gonna disappear altogether thanks to https://bugs.webkit.org/show_bug.cgi?id=38179
Comment 6 Kenneth Rohde Christiansen 2010-04-29 05:29:58 PDT
Comment on attachment 54686 [details]
Patch for Qt only

I support this change!
Comment 7 WebKit Commit Bot 2010-04-29 07:08:36 PDT
Comment on attachment 54686 [details]
Patch for Qt only

Rejecting patch 54686 from commit-queue.

Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Kenneth Rohde Christiansen', u'--force']" exit_code: 1
Parsed 4 diffs from patch file(s).
patching file WebKit/qt/Api/qwebpage.cpp
Hunk #1 FAILED at 127.
Hunk #2 succeeded at 2104 (offset 4 lines).
1 out of 2 hunks FAILED -- saving rejects to file WebKit/qt/Api/qwebpage.cpp.rej
patching file WebKit/qt/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp
Hunk #1 succeeded at 347 (offset 5 lines).
patching file WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp

Full output: http://webkit-commit-queue.appspot.com/results/1851187
Comment 8 Benjamin Poulain 2010-04-29 07:39:30 PDT
Created attachment 54706 [details]
Patch for Qt only

Luiz was faster than me to patch QWebPage :) 
Same patch updated without conflict.
Comment 9 WebKit Commit Bot 2010-04-29 10:35:21 PDT
Comment on attachment 54706 [details]
Patch for Qt only

Clearing flags on attachment: 54706

Committed r58523: <http://trac.webkit.org/changeset/58523>
Comment 10 WebKit Commit Bot 2010-04-29 10:35:28 PDT
All reviewed patches have been landed.  Closing bug.