RESOLVED FIXED 38191
Revert 58274 and 58269 (WebSQLDatabase changes) 
https://bugs.webkit.org/show_bug.cgi?id=38191
Summary Revert 58274 and 58269 (WebSQLDatabase changes)
Jeremy Orlow
Reported 2010-04-27 04:14:36 PDT
Revert 58274 and 58269 (WebSQLDatabase changes)
Attachments
Patch (13.80 KB, patch)
2010-04-27 04:15 PDT, Jeremy Orlow 		no flags
DetailsFormatted DiffDiff
patch (14.74 KB, patch)
2010-04-27 16:20 PDT, Dumitru Daniliuc 		levin: review-
dumi: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jeremy Orlow
Comment 1 2010-04-27 04:15:57 PDT
Created attachment 54408 [details] Patch
Jeremy Orlow
Comment 2 2010-04-27 04:20:32 PDT
Reverted these: http://trac.webkit.org/changeset/58274 http://trac.webkit.org/changeset/58270 Some additional info, tho this is super easy to repro: http://code.google.com/p/chromium/issues/detail?id=42618#makechanges
Jeremy Orlow
Comment 3 2010-04-27 04:20:52 PDT
Comment on attachment 54408 [details] Patch Committed
Jeremy Orlow
Comment 4 2010-04-27 05:07:08 PDT
Landed http://trac.webkit.org/changeset/58302 to revert. And http://trac.webkit.org/changeset/58303 to disable the quota test in Chromium until Dumi can take a look.
Dumitru Daniliuc
Comment 5 2010-04-27 16:20:30 PDT
Created attachment 54469 [details] patch Same patch as before + all necessary fixes to storage/quota-tracking.html. The Chromium-side fix (that will go in first) is at http://codereview.chromium.org/1709014.
David Levin
Comment 6 2010-04-27 17:23:26 PDT
Comment on attachment 54469 [details] patch I think this patch is attached to the wrong bug. The bug says that it needs to revert some changes, and this instead appears to be turning on AUTO_VACUUM. Sorry but r- b/c this is too confusing.
Dumitru Daniliuc
Comment 7 2010-04-27 17:28:22 PDT
(In reply to comment #6) > (From update of attachment 54469 [details]) > I think this patch is attached to the wrong bug. The bug says that it needs to > revert some changes, and this instead appears to be turning on AUTO_VACUUM. > Sorry but r- b/c this is too confusing. ok, i'll close this bug and attach the patch to bug 36251. please take a look if you have time.
Note You need to log in before you can comment on or make changes to this bug.