Bug 38191 - Revert 58274 and 58269 (WebSQLDatabase changes)
Summary: Revert 58274 and 58269 (WebSQLDatabase changes)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Dumitru Daniliuc
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-27 04:14 PDT by Jeremy Orlow
Modified: 2010-04-27 17:28 PDT (History)
2 users (show)

See Also:


Attachments
Patch (13.80 KB, patch)
2010-04-27 04:15 PDT, Jeremy Orlow
no flags Details | Formatted Diff | Diff
patch (14.74 KB, patch)
2010-04-27 16:20 PDT, Dumitru Daniliuc
levin: review-
dumi: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Orlow 2010-04-27 04:14:36 PDT
Revert 58274 and 58269 (WebSQLDatabase changes)
Comment 1 Jeremy Orlow 2010-04-27 04:15:57 PDT
Created attachment 54408 [details]
Patch
Comment 2 Jeremy Orlow 2010-04-27 04:20:32 PDT
Reverted these:
http://trac.webkit.org/changeset/58274
http://trac.webkit.org/changeset/58270

Some additional info, tho this is super easy to repro:
http://code.google.com/p/chromium/issues/detail?id=42618#makechanges
Comment 3 Jeremy Orlow 2010-04-27 04:20:52 PDT
Comment on attachment 54408 [details]
Patch

Committed
Comment 4 Jeremy Orlow 2010-04-27 05:07:08 PDT
Landed http://trac.webkit.org/changeset/58302 to revert.

And http://trac.webkit.org/changeset/58303 to disable the quota test in Chromium until Dumi can take a look.
Comment 5 Dumitru Daniliuc 2010-04-27 16:20:30 PDT
Created attachment 54469 [details]
patch

Same patch as before + all necessary fixes to storage/quota-tracking.html. The Chromium-side fix (that will go in first) is at http://codereview.chromium.org/1709014.
Comment 6 David Levin 2010-04-27 17:23:26 PDT
Comment on attachment 54469 [details]
patch

I think this patch is attached to the wrong bug. The bug says that it needs to revert some changes, and this instead appears to be turning on AUTO_VACUUM. Sorry but r- b/c this is too confusing.
Comment 7 Dumitru Daniliuc 2010-04-27 17:28:22 PDT
(In reply to comment #6)
> (From update of attachment 54469 [details])
> I think this patch is attached to the wrong bug. The bug says that it needs to
> revert some changes, and this instead appears to be turning on AUTO_VACUUM.
> Sorry but r- b/c this is too confusing.

ok, i'll close this bug and attach the patch to bug 36251. please take a look if you have time.