RESOLVED FIXED 38184
Hitting the 'backspace' key may go back twice 
https://bugs.webkit.org/show_bug.cgi?id=38184
Summary Hitting the 'backspace' key may go back twice
Jon Honeycutt
Reported 2010-04-27 01:53:17 PDT
Created attachment 54398 [details] patch Hitting the 'backspace' key may go back twice. <rdar://problem/7911140>
Attachments
patch (2.07 KB, patch)
2010-04-27 01:53 PDT, Jon Honeycutt 		mjs: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Maciej Stachowiak
Comment 1 2010-04-27 02:19:07 PDT
Comment on attachment 54398 [details] patch r=me
Darin Adler
Comment 2 2010-04-27 13:19:37 PDT
Comment on attachment 54398 [details] patch We might want to consider returning true even if goForward or goBack returs false. It can be useful to consider even making the attempt to go forward/back as consuming the key event. In practice this probably doesn't matter. One case where we do want logic like what you added here is scrolling keys such as page down and arrow keys, where we want to not consume the key since the key could go on to scroll a container.
Jon Honeycutt
Comment 3 2010-04-27 14:12:09 PDT
(In reply to comment #2) > (From update of attachment 54398 [details]) > We might want to consider returning true even if goForward or goBack returs > false. It can be useful to consider even making the attempt to go forward/back > as consuming the key event. In practice this probably doesn't matter. > I'm going to land this as-is, but I will consider your suggestion.
Jon Honeycutt
Comment 4 2010-04-27 14:36:17 PDT
Landed in r58337.
Note You need to log in before you can comment on or make changes to this bug.