Bug 38183 – REGRESSION (r57919): Some pages opened in background tabs don't render the first time you activate their tab

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Maciej Stachowiak]

REGRESSION (r57919): Some pages opened in background tabs don't render the first time you activate their tab

[Maciej Stachowiak]

Created attachment 54399 [details]
Patch

[Maciej Stachowiak]

        <rdar://problem/7900419>

[Dave Hyatt]

Comment on attachment 54399 [details]
Patch

It's pretty sloppy to have a platform ifdef right in a rendering file, but if it's unavoidable...

[Simon Fraser (smfr)]

Hmm, maybe we could hide the #ifdef inside a new method, RenderLayerCompositor::compositeAcrossIFrames() or something.

[Simon Fraser (smfr)]

Comment on attachment 54399 [details]
Patch

I filed bug 38206 on the underlying issue here. I'll take this, and do a cleaner patch.

[Simon Fraser (smfr)]

Created attachment 54437 [details]
Patch

[Darin Adler]

Comment on attachment 54437 [details]
Patch

> +bool RenderLayerCompositor::shouldPropagateCompositingToParentDocument() const
> +{
> +#if !PLATFORM(MAC)
> +    return true;
> +#else
> +    return false;
> +#endif
> +}

I’d like to see a “why” comment in this function. This seems the perfect place to explain why Mac is different, if we know why.

[Maciej Stachowiak]

Comment on attachment 54437 [details]
Patch

Comments from offline discussion:

1) shouldPropagateCompositingToParentDocument should be renamed to something like shouldPropagateCompositingToIFrameParent
2) shouldPropagateCompositingToIFrameParent should probably be a static method
3) The shouldPropagateCompositingToIFrameParent check should probably be in RenderLayerCompositor instead of in RenderView, because it's part of the decision about *when* to update the compositing state, rather than an implementation detail of *how* the RenderView does so.
4) Please add the manual-test from my patch.

[Simon Fraser (smfr)]

http://trac.webkit.org/changeset/58320