RESOLVED FIXED 38177
Add specialized thunks for a char code related string functions 
https://bugs.webkit.org/show_bug.cgi?id=38177
Summary Add specialized thunks for a char code related string functions
Oliver Hunt
Reported 2010-04-26 23:57:50 PDT
Add specialized thunks for a char code related string functions
Attachments
Patch (9.25 KB, patch)
2010-04-27 00:00 PDT, Oliver Hunt 		mjs: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2010-04-27 00:00:26 PDT
Created attachment 54389 [details] Patch
Maciej Stachowiak
Comment 2 2010-04-27 00:14:35 PDT
Comment on attachment 54389 [details] Patch JavaScriptCore/ChangeLog:17 + (JSC::SpecializedThunkJIT::tagReturnAsJSCell): I know this comment is a bit late, but I think the term "thunk" for these doesn't match standard usage. Doesn't match any of the definitions here: http://en.wikipedia.org/wiki/Thunk I can't think of an accurate but brief term offhand. Maybe "Stub", though we also have JIT stubs. Patch otherwise looks correct. Please double-check that there is really a perf gain, if so, r=me.
Oliver Hunt
Comment 3 2010-04-27 11:17:48 PDT
Committed r58317: <http://trac.webkit.org/changeset/58317>
WebKit Review Bot
Comment 4 2010-04-27 11:42:30 PDT
http://trac.webkit.org/changeset/58317 might have broken Qt Linux ARMv5 Release
Note You need to log in before you can comment on or make changes to this bug.