Bug 38173 - Fix JSC binding generation to match webkit style
Summary: Fix JSC binding generation to match webkit style
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-26 22:48 PDT by Eric Seidel (no email)
Modified: 2010-05-07 20:17 PDT (History)
1 user (show)

See Also:


Attachments
Patch (11.69 KB, patch)
2010-04-26 22:50 PDT, Eric Seidel (no email)
abarth: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2010-04-26 22:48:15 PDT
Fix JSC binding generation to match webkit style
Comment 1 Eric Seidel (no email) 2010-04-26 22:50:43 PDT
Created attachment 54384 [details]
Patch
Comment 2 Adam Barth 2010-04-26 23:03:31 PDT
Comment on attachment 54384 [details]
Patch

You should add more test coverage for the cases we're not testing yet.
Comment 3 WebKit Commit Bot 2010-04-27 00:47:56 PDT
Comment on attachment 54384 [details]
Patch

Rejecting patch 54384 from commit-queue.

Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Adam Barth', u'--force']" exit_code: 1
patching file WebCore/ChangeLog
patching file WebCore/bindings/scripts/CodeGeneratorJS.pm
patching file WebCore/bindings/scripts/test/JS/JSTestObj.cpp
Hunk #1 succeeded at 46 (offset 2 lines).
Hunk #2 succeeded at 56 (offset 2 lines).
Hunk #3 FAILED at 130.
1 out of 3 hunks FAILED -- saving rejects to file WebCore/bindings/scripts/test/JS/JSTestObj.cpp.rej
patching file WebKitTools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file WebKitTools/Scripts/run-bindings-tests

Full output: http://webkit-commit-queue.appspot.com/results/1917010
Comment 4 Eric Seidel (no email) 2010-05-02 19:32:36 PDT
Attachment 54384 [details] was posted by a committer and has review+, assigning to Eric Seidel for commit.
Comment 5 Eric Seidel (no email) 2010-05-07 20:17:03 PDT
Committed r58992: <http://trac.webkit.org/changeset/58992>