RESOLVED FIXED Bug 38167
Add testing infrastructure for JSC bindings generator 
https://bugs.webkit.org/show_bug.cgi?id=38167
Summary Add testing infrastructure for JSC bindings generator
Adam Barth
Reported 2010-04-26 21:31:19 PDT
Add testing infrastructure for JSC bindings generator
Attachments
Patch (42.29 KB, patch)
2010-04-26 21:33 PDT, Adam Barth 		eric: review+
eric: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-04-26 21:33:34 PDT
Created attachment 54379 [details] Patch
Eric Seidel (no email)
Comment 2 2010-04-26 21:42:12 PDT
Comment on attachment 54379 [details] Patch WebCore/ChangeLog:67 + * bindings/scripts/test/V8/V8TestObj.cpp: Renamed from WebCore/bindings/scripts/test/V8TestObj.cpp. It's unclear to me why these moved from v8/test to test/v8. Seems slightly silly. WebCore/bindings/scripts/test/JS/JSTestObj.cpp:6 + modify it under the terms of the GNU Library General Public Why are we generating LGPL code? Also seems silly. But that's something to fix later. WebKitTools/Scripts/run-bindings-tests:46 + # place holder for defines (generate-bindings.pl requirement) This comment is no longer valid. WebKitTools/Scripts/run-bindings-tests:118 + # FIXME: Add ObjC COM too? Or did we kill COM? WebKitTools/Scripts/run-bindings-tests:123 + os.path.join('WebCore', 'bindings', 'scripts', 'test'), # Input dir I would have put the big joins into little local vars first. Looks OK.
Adam Barth
Comment 3 2010-04-26 21:50:05 PDT
Comments addressed and landed in r58288
Note You need to log in before you can comment on or make changes to this bug.