Bug 38166 - REGRESSION(r58283): "Appears to have broken every build." (Requested by eseidel on #webkit).
Summary: REGRESSION(r58283): "Appears to have broken every build." (Requested by eseid...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 38163
  Show dependency tree / graph
 
Reported: 2010-04-26 21:13 PDT by WebKit Review Bot
Modified: 2010-04-26 21:37 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Review Bot 2010-04-26 21:13:21 PDT 
http://trac.webkit.org/changeset/58283 broke the build:
"Appears to have broken every build." (Requested by eseidel on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear
Comment 1 Oliver Hunt 2010-04-26 21:14:01 PDT 
why the hell is there a bug for build breakage?
Comment 2 Adam Barth 2010-04-26 21:15:12 PDT 
(In reply to comment #1)
> why the hell is there a bug for build breakage?

Because our process to create bugs for the changes we make to the code.
Comment 3 Eric Seidel (no email) 2010-04-26 21:16:06 PDT 
Sherriffbot was supposed to add a rollout patch to this bug, but failed to do so due to a regression earlier today.  Sorry for the noise.
Comment 4 Oliver Hunt 2010-04-26 21:17:21 PDT 
(In reply to comment #2)
> (In reply to comment #1)
> > why the hell is there a bug for build breakage?
> 
> Because our process to create bugs for the changes we make to the code.

Hasn't ever been required for trivial build fixes.
Comment 5 Adam Barth 2010-04-26 21:18:48 PDT 
> Hasn't ever been required for trivial build fixes.

Indeed.  Thanks for fixing the build.  We didn't see you on IRC or on bugs.webkit.org, so we weren't sure what the status of this issue was, hence we created this issue to track the problem.
Comment 6 Oliver Hunt 2010-04-26 21:22:01 PDT 
(In reply to comment #5)
> > Hasn't ever been required for trivial build fixes.
> 
> Indeed.  Thanks for fixing the build.  We didn't see you on IRC or on
> bugs.webkit.org, so we weren't sure what the status of this issue was, hence we
> created this issue to track the problem.

I am always on irc, just not in #webkit due to the ever decreasing signal/noise ratio, a pm would also have reached me, and i figured fixing the build was more important than commenting about fixing it :D
Comment 7 Adam Barth 2010-04-26 21:37:26 PDT 
> I am always on irc, just not in #webkit due to the ever decreasing signal/noise
> ratio, a pm would also have reached me, and i figured fixing the build was more
> important than commenting about fixing it :D

That's good to know for the future.  There were a bunch of folks on #webkit wondering what to do about the failure, so it might be useful to let someone know you're alive and aware of the problem so we can avoid duplicating effort.  In the past, we've had trouble with folks breaking the tree and disappearing, so it's good to be clear about who's going to fix failures.