Bug 38159 - [chromium] Fix ChromiumDataObject::setURL to not populate its internal URL list with empty URLs
Summary: [chromium] Fix ChromiumDataObject::setURL to not populate its internal URL li...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Windows 7
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-26 17:58 PDT by Daniel Cheng
Modified: 2010-04-26 20:07 PDT (History)
3 users (show)

See Also:


Attachments
Fix for ChromiumDataObject::setURL (1023 bytes, patch)
2010-04-26 17:58 PDT, Daniel Cheng
no flags Details | Formatted Diff | Diff
Fix for ChromiumDataObject::setURL (1.02 KB, patch)
2010-04-26 18:04 PDT, Daniel Cheng
no flags Details | Formatted Diff | Diff
Fix for ChromiumDataObject::setURL (1014 bytes, patch)
2010-04-26 18:15 PDT, Daniel Cheng
no flags Details | Formatted Diff | Diff
Fix for ChromiumDataObject::setURL (1.05 KB, patch)
2010-04-26 18:17 PDT, Daniel Cheng
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Cheng 2010-04-26 17:58:04 PDT
Created attachment 54357 [details]
Fix for ChromiumDataObject::setURL

This wouldn't be a problem except that it appends URLs to an internal list. The fix should be to not append empty URLs; otherwise, asserts in getData will be triggered.
Comment 1 WebKit Review Bot 2010-04-26 18:02:52 PDT
Attachment 54357 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebCore/platform/chromium/ChromiumDataObject.h:80:  Tab found; better to use spaces  [whitespace/tab] [1]
WebCore/platform/chromium/ChromiumDataObject.h:81:  Tab found; better to use spaces  [whitespace/tab] [1]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 2 Daniel Cheng 2010-04-26 18:04:46 PDT
Created attachment 54359 [details]
Fix for ChromiumDataObject::setURL

Removed the tabs that VS inserted.
Comment 3 Daniel Cheng 2010-04-26 18:15:31 PDT
Created attachment 54363 [details]
Fix for ChromiumDataObject::setURL

Move the return, per the discussion.
Comment 4 Daniel Cheng 2010-04-26 18:17:38 PDT
Created attachment 54365 [details]
Fix for ChromiumDataObject::setURL

Fix ChangeLog
Comment 5 Jian Li 2010-04-26 18:20:25 PDT
Comment on attachment 54365 [details]
Fix for ChromiumDataObject::setURL

r=me
Comment 6 WebKit Commit Bot 2010-04-26 20:07:46 PDT
Comment on attachment 54365 [details]
Fix for ChromiumDataObject::setURL

Clearing flags on attachment: 54365

Committed r58280: <http://trac.webkit.org/changeset/58280>
Comment 7 WebKit Commit Bot 2010-04-26 20:07:51 PDT
All reviewed patches have been landed.  Closing bug.