Bug 38155 - Need to support more efficient dispatch of lightweight builtins
Summary: Need to support more efficient dispatch of lightweight builtins
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-26 17:44 PDT by Oliver Hunt
Modified: 2010-04-26 21:23 PDT (History)
1 user (show)

See Also:


Attachments
Patch (63.19 KB, patch)
2010-04-26 18:34 PDT, Oliver Hunt
barraclough: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2010-04-26 17:44:06 PDT
Need to support more efficient dispatch of lightweight builtins
Comment 1 Oliver Hunt 2010-04-26 18:34:28 PDT
Created attachment 54369 [details]
Patch
Comment 2 WebKit Review Bot 2010-04-26 18:35:54 PDT
Attachment 54369 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
JavaScriptCore/runtime/Lookup.h:80:  More than one command on the same line  [whitespace/newline] [4]
JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:1707:  One or more unexpected \r (^M) found; better to use only a \n  [whitespace/carriage_return] [1]
Suppressing further [whitespace/carriage_return] reports for this file.
JavaScriptCore/jit/JSInterfaceJIT.h:38:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
JavaScriptCore/jit/SpecializedThunkJIT.h:37:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
JavaScriptCore/jit/ThunkGenerators.h:33:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 20 in 27 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Oliver Hunt 2010-04-26 18:37:50 PDT
(In reply to comment #2)
> Attachment 54369 [details] did not pass style-queue:
> 
> Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']"
> exit_code: 1
> JavaScriptCore/runtime/Lookup.h:80:  More than one command on the same line 
> [whitespace/newline] [4]
> JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:1707:
>  One or more unexpected \r (^M) found; better to use only a \n 
> [whitespace/carriage_return] [1]
> Suppressing further [whitespace/carriage_return] reports for this file.
> JavaScriptCore/jit/JSInterfaceJIT.h:38:  Code inside a namespace should not be
> indented.  [whitespace/indent] [4]
> JavaScriptCore/jit/SpecializedThunkJIT.h:37:  Code inside a namespace should
> not be indented.  [whitespace/indent] [4]
> JavaScriptCore/jit/ThunkGenerators.h:33:  Code inside a namespace should not be
> indented.  [whitespace/indent] [4]
> Total errors found: 20 in 27 files
> 
> 
> If any of these errors are false positives, please file a bug against
> check-webkit-style.

style bot is wrong here -- code inside a namespace in a .h file should be indented.  \r should be used in the vcproj, lookup.h has an assert as the first command which is also allowed.
Comment 4 Gavin Barraclough 2010-04-26 20:26:50 PDT
Comment on attachment 54369 [details]
Patch

Please split this patch into two, and land the file moves separately.
Also, please remove the friend from StringImpl - add a static method to access the offset of m_data instead.
Comment 5 Oliver Hunt 2010-04-26 21:23:01 PDT
Committed r58286: <http://trac.webkit.org/changeset/58286>