Bug 38126 - [Chromium] Create new baseline for caret-rtl-2
Summary: [Chromium] Create new baseline for caret-rtl-2
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Xiaomei Ji
URL:
Keywords:
Depends on:
Blocks: 38109
  Show dependency treegraph
 
Reported: 2010-04-26 07:17 PDT by Jeremy Orlow
Modified: 2010-04-27 16:03 PDT (History)
4 users (show)

See Also:


Attachments
Patch (16.84 KB, patch)
2010-04-26 07:24 PDT, Jeremy Orlow
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Orlow 2010-04-26 07:17:14 PDT
[Chromium] Create new baseline for caret-rtl-2
Comment 1 Jeremy Orlow 2010-04-26 07:24:54 PDT
Created attachment 54296 [details]
Patch
Comment 2 Dimitri Glazkov (Google) 2010-04-26 07:36:25 PDT
Xiaomei, can you check to see if the baseline is right?
Comment 3 Xiaomei Ji 2010-04-26 09:54:07 PDT
Yes. that is correct. The caret is at the very left after the fix of issue 25319.
Comment 4 Jeremy Orlow 2010-04-26 09:57:47 PDT
Is the (non-chromium) baseline correct (and thus we should land this patch) or should it have been updated as well (and thus you should generate a proper baseline and we'll throw this patch away)?
Comment 5 Xiaomei Ji 2010-04-26 10:19:04 PDT
Sorry for the trouble. I should re-baseline several tests including this one.
Comment 6 Jeremy Orlow 2010-04-26 10:25:59 PDT
No problem.  Was just trying to understand the situation.  I'll turn the bug over to you for generating baselines?
Comment 7 Xiaomei Ji 2010-04-26 16:30:51 PDT
Surprisingly, this test does not fail in webkit mac debug and release build even turn on --tolerance=0.

So, we will need to land this patch for chromium only.

Also, the test fails in chromium windows too. I have not tested in Linux yet.
Then, should we create a new baseline for windows and linux too?
Comment 8 Jeremy Orlow 2010-04-27 02:59:04 PDT
It's been marked as something that will always fail on Win/Linux.  Please look into why this is.  It'd be great if we could add test coverage just by turning on an existing test!

Anyway, Dimitri, can you r+ this?
Comment 9 Dimitri Glazkov (Google) 2010-04-27 07:30:56 PDT
Comment on attachment 54296 [details]
Patch

ok.
Comment 10 WebKit Commit Bot 2010-04-27 16:03:09 PDT
Comment on attachment 54296 [details]
Patch

Clearing flags on attachment: 54296

Committed r58348: <http://trac.webkit.org/changeset/58348>
Comment 11 WebKit Commit Bot 2010-04-27 16:03:15 PDT
All reviewed patches have been landed.  Closing bug.