Bug 38121 - new-rwt: Fix function call with wrong number of arguments
Summary: new-rwt: Fix function call with wrong number of arguments
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
: 38033 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-04-26 06:03 PDT by Tor Arne Vestbø
Modified: 2011-03-18 18:40 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.29 KB, patch)
2010-04-26 07:30 PDT, Tor Arne Vestbø 		eric: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tor Arne Vestbø 2010-04-26 06:03:01 PDT 
new-rwt: Fix function call with wrong number of arguments
Comment 1 Tor Arne Vestbø 2010-04-26 07:30:18 PDT 
Created attachment 54298 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-04-26 11:13:37 PDT 
*** Bug 38033 has been marked as a duplicate of this bug. ***
Comment 3 Eric Seidel (no email) 2010-04-26 11:14:18 PDT 
Comment on attachment 54298 [details]
Patch

LGTM.
Comment 4 Eric Seidel (no email) 2010-04-26 11:14:33 PDT 
We really need to be unit testing this code.
Comment 5 Adam Barth 2010-04-26 15:54:44 PDT 
I don't think we should be landing changes like this without a unit test.
Comment 6 Eric Seidel (no email) 2010-04-26 15:56:07 PDT 
Comment on attachment 54298 [details]
Patch

Adam has convinced me.  We need to require unit tests. Even for fixing the scripts to run.

This shouldn't be too hard to test.
Comment 7 Dirk Pranke 2010-04-26 16:15:52 PDT 
Comment on attachment 54298 [details]
Patch

Note that this code all changes completely with the patch for 38018, which does have unit tests. We might as well hold off on this.
Comment 8 Dirk Pranke 2011-03-18 18:40:41 PDT 
closing as no longer relevant.