RESOLVED FIXED 38121
new-rwt: Fix function call with wrong number of arguments 
https://bugs.webkit.org/show_bug.cgi?id=38121
Summary new-rwt: Fix function call with wrong number of arguments
Tor Arne Vestbø
Reported 2010-04-26 06:03:01 PDT
new-rwt: Fix function call with wrong number of arguments
Attachments
Patch (2.29 KB, patch)
2010-04-26 07:30 PDT, Tor Arne Vestbø 		eric: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tor Arne Vestbø
Comment 1 2010-04-26 07:30:18 PDT
Created attachment 54298 [details] Patch
Eric Seidel (no email)
Comment 2 2010-04-26 11:13:37 PDT
*** Bug 38033 has been marked as a duplicate of this bug. ***
Eric Seidel (no email)
Comment 3 2010-04-26 11:14:18 PDT
Comment on attachment 54298 [details] Patch LGTM.
Eric Seidel (no email)
Comment 4 2010-04-26 11:14:33 PDT
We really need to be unit testing this code.
Adam Barth
Comment 5 2010-04-26 15:54:44 PDT
I don't think we should be landing changes like this without a unit test.
Eric Seidel (no email)
Comment 6 2010-04-26 15:56:07 PDT
Comment on attachment 54298 [details] Patch Adam has convinced me. We need to require unit tests. Even for fixing the scripts to run. This shouldn't be too hard to test.
Dirk Pranke
Comment 7 2010-04-26 16:15:52 PDT
Comment on attachment 54298 [details] Patch Note that this code all changes completely with the patch for 38018, which does have unit tests. We might as well hold off on this.
Dirk Pranke
Comment 8 2011-03-18 18:40:41 PDT
closing as no longer relevant.
Note You need to log in before you can comment on or make changes to this bug.