Bug 38106 - [chromium] Check and rebaseline SVG test expectations for Chromium
Summary: [chromium] Check and rebaseline SVG test expectations for Chromium
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Jeremy Orlow
Depends on: 37986
  Show dependency treegraph
Reported: 2010-04-26 00:26 PDT by Yuzo Fujishima
Modified: 2010-08-10 22:23 PDT (History)
9 users (show)

See Also:

Patch (2.05 KB, patch)
2010-04-26 01:22 PDT, Tony Chang
no flags Details | Formatted Diff | Diff
Rebaseline SVG layout tests (781.70 KB, patch)
2010-04-28 09:05 PDT, Marcus Bulach
jorlow: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yuzo Fujishima 2010-04-26 00:26:29 PDT
has changed SVG rendering.

SVG test expectations for Chromium need to be changed accordingly.
Comment 1 Yuzo Fujishima 2010-04-26 01:03:03 PDT
Committed r58239: <http://trac.webkit.org/changeset/58239>
Comment 2 Yuzo Fujishima 2010-04-26 01:03:37 PDT
Just changed test expectation.
The issue remains.
Comment 3 Tony Chang 2010-04-26 01:22:45 PDT
Created attachment 54265 [details]
Comment 4 Tony Chang 2010-04-26 01:24:00 PDT
Committed r58241: <http://trac.webkit.org/changeset/58241>
Comment 5 Tony Chang 2010-04-26 01:25:22 PDT
Comment on attachment 54265 [details]

Cleaned up some duplicate expectations.
Comment 6 Jeremy Orlow 2010-04-26 03:26:51 PDT
All failures can be seen here: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&useWebKitCanary=true&tests=svg%2FW3C-SVG-1.1%2Fanimate-elem-31-t.svg%2Csvg%2FW3C-SVG-1.1%2Fanimate-elem-78-t.svg%2Csvg%2FW3C-SVG-1.1%2Fcolor-prop-01-b.svg%2Csvg%2FW3C-SVG-1.1%2Fcoords-units-01-b.svg%2Csvg%2FW3C-SVG-1.1%2Ffilters-color-01-b.svg%2Csvg%2FW3C-SVG-1.1%2Ffilters-comptran-01-b.svg%2Csvg%2FW3C-SVG-1.1%2Fpainting-render-01-b.svg%2Csvg%2FW3C-SVG-1.1%2Fpservers-grad-01-b.svg%2Csvg%2FW3C-SVG-1.1%2Fpservers-grad-02-b.svg%2Csvg%2FW3C-SVG-1.1%2Fpservers-grad-03-b.svg%2Csvg%2FW3C-SVG-1.1%2Fpservers-grad-04-b.svg%2Csvg%2FW3C-SVG-1.1%2Fpservers-grad-06-b.svg%2Csvg%2FW3C-SVG-1.1%2Fpservers-grad-07-b.svg%2Csvg%2FW3C-SVG-1.1%2Fpservers-grad-09-b.svg%2Csvg%2FW3C-SVG-1.1%2Fpservers-grad-11-b.svg%2Csvg%2FW3C-SVG-1.1%2Fpservers-grad-12-b.svg%2Csvg%2FW3C-SVG-1.1%2Fpservers-grad-13-b.svg%2Csvg%2FW3C-SVG-1.1%2Fpservers-grad-14-b.svg%2Csvg%2FW3C-SVG-1.1%2Fpservers-grad-15-b.svg%2Csvg%2FW3C-SVG-1.1%2Fpservers-grad-16-b.svg%2Csvg%2FW3C-SVG-1.1%2Fpservers-grad-17-b.svg%2Csvg%2FW3C-SVG-1.1%2Fpservers-grad-18-b.svg%2Csvg%2FW3C-SVG-1.1%2Fpservers-pattern-01-b.svg%2Csvg%2FW3C-SVG-1.1%2Fstruct-group-03-t.svg%2Csvg%2FW3C-SVG-1.1%2Fstruct-use-05-b.svg%2Csvg%2FW3C-SVG-1.1%2Fstyling-inherit-01-b.svg%2Csvg%2Fbatik%2Ffilters%2FfeTile.svg%2Csvg%2Fbatik%2Fmasking%2FmaskRegions.svg%2Csvg%2Fbatik%2Fpaints%2FgradientLimit.svg%2Csvg%2Fbatik%2Fpaints%2FpatternRegionA.svg%2Csvg%2Fbatik%2Fpaints%2FpatternRegions.svg%2Csvg%2Fbatik%2Ftext%2FtextEffect.svg%2Csvg%2Fbatik%2Ftext%2FtextEffect2.svg%2Csvg%2Fbatik%2Ftext%2FtextEffect3.svg%2Csvg%2Fbatik%2Ftext%2FtextProperties.svg%2Csvg%2Fcarto.net%2Ftabgroup.svg%2Csvg%2Fcustom%2FfeComponentTransfer-Discrete.svg%2Csvg%2Fcustom%2FfeComponentTransfer-Gamma.svg%2Csvg%2Fcustom%2FfeComponentTransfer-Linear.svg%2Csvg%2Fcustom%2FfeComponentTransfer-Table.svg%2Csvg%2Fcustom%2Ffill-fallback.svg%2Csvg%2Fcustom%2Fgradient-cycle-detection.svg%2Csvg%2Fcustom%2Fgradient-deep-referencing.svg%2Csvg%2Fcustom%2Finline-svg-in-xhtml.xml%2Csvg%2Fcustom%2Finvalid-css.svg%2Csvg%2Fcustom%2Fjs-late-gradient-and-object-creation.svg%2Csvg%2Fcustom%2Fjs-late-gradient-creation.svg%2Csvg%2Fcustom%2Fjs-late-pattern-and-object-creation.svg%2Csvg%2Fcustom%2Fjs-late-pattern-creation.svg%2Csvg%2Fcustom%2Fpattern-cycle-detection.svg%2Csvg%2Fcustom%2Fpattern-deep-referencing.svg%2Csvg%2Fcustom%2Fpattern-with-transformation.svg%2Csvg%2Fcustom%2Fstroke-fallback.svg%2Csvg%2Fcustom%2Fstroked-pattern.svg%2Csvg%2Fcustom%2Fuse-on-symbol-inside-pattern.svg%2Csvg%2Fhixie%2Ferror%2F003.xml%2Csvg%2Ftext%2Fselection-background-color.xhtml%2Csvg%2Ftext%2Fselection-styles.xhtml%2Csvg%2Ftext%2Ftext-gradient-positioning.svg%2Cfast%2Fbackgrounds%2Fsvg-as-background-2.html%2Csvg%2Fcustom%2Fgradient-stroke-width.svg%2Csvg%2Fcustom%2Fjs-update-gradient.svg%2Csvg%2FW3C-SVG-1.1%2Fmasking-mask-01-b.svg%2Csvg%2FW3C-SVG-1.1%2Fpservers-grad-05-b.svg%2Csvg%2FW3C-SVG-1.1%2Fpservers-grad-19-b.svg%2Csvg%2Fcustom%2Fdominant-baseline-hanging.svg
Comment 7 Jeremy Orlow 2010-04-26 05:32:40 PDT
http://trac.webkit.org/changeset/58244 may be related to this bug as well.
Comment 8 Dimitri Glazkov (Google) 2010-04-27 10:06:25 PDT
Are you guys planning to submit new baselines for these? It's been a few days now.
Comment 9 Jeremy Orlow 2010-04-27 10:11:27 PDT
I don't get it....were you planning on doing the rebaslining Yuzo?  If not, you either shouldn't have rolled the stuff in or (at very least) assigned a bug to someone to do it.

Anyway, I'll take this on.
Comment 10 Jeremy Orlow 2010-04-27 10:47:48 PDT
Tomorrow that is.
Comment 11 Yuzo Fujishima 2010-04-27 17:31:18 PDT
Sorry about this.
It was too big a regression for me to handle myself,
and I don't know how to find a good assignee.
(And I assumed that filing a bug is enough, which seems to be wrong.)

What is the good way to find a relevant (Chromium) developer?
Comment 12 Jeremy Orlow 2010-04-28 02:01:21 PDT
(In reply to comment #11)
> Sorry about this.
> It was too big a regression for me to handle myself,
> and I don't know how to find a good assignee.
> (And I assumed that filing a bug is enough, which seems to be wrong.)

Filing a chrome bug used to just work out because Dimitri triaged them all, but most webkit bugs just get lost in the void.
> What is the good way to find a relevant (Chromium) developer?

I assume you were the last Gardener?  If so, probably what you should have done was rebaseline everything but then send the review to someone who knows SVG.  svn blameing one of the SVG directories for someone from Chrome would have been a start.  You could have also cc'ed someone like Dimitri and asked for help.

Anyway, we caught it early, so it's not that big of a deal.
Comment 13 Dimitri Glazkov (Google) 2010-04-28 07:44:22 PDT
(In reply to comment #11)
> Sorry about this.
> It was too big a regression for me to handle myself,
> and I don't know how to find a good assignee.
> (And I assumed that filing a bug is enough, which seems to be wrong.)

I am wondering why you felt it was a difficult problem. Let me try to explain my approach to diagnosing it, hopefully it'll be useful in the future gardening stints.

The dashboard (see Jeremy's link in comment 6) clearly fingers http://trac.webkit.org/log/?verbose=on&rev=58212&stop_rev=58212, which is one revision that caused all these changes.

When you look at the log, this revision changes expectations for a large list of tests that matches nearly one-to-one the list of failures on the canaries.

If you look at the diffs on the new expectations, checked in at r58212 and compare them with the expectation changes on the dashboard, you'll see that they add the same type of RenderTree output:


Then we read up on the type of the change in the excellent ChangeLog that Nikolas provided and conclude that yes, all these are valid adjustments. You can even cc him (I just did) on the bug or ask on #webkit (he's WildFox) whether that's correct.

The tedious task of determining that is, well, tedious, but shouldn't take more than 30 mins.

The rest is easy -- just run rebaselining tool and commit the diffs. Does this make any sense?
Comment 15 Dimitri Glazkov (Google) 2010-04-28 08:38:53 PDT
(In reply to comment #14)
> svg-as-background-2.html might be a real failure
> http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Fbackgrounds%2Fsvg-as-background-2.html&showExpectations=true&useWebKitCanary=true

Yes indeed! It fails for WebKit/mac too.
Comment 16 Jeremy Orlow 2010-04-28 08:52:04 PDT
Actually, https://bugs.webkit.org/show_bug.cgi?id=38108 is already open for addressing fallout from that change.  Let's continue discussion about svg-as-background-2.html there.
Comment 17 Marcus Bulach 2010-04-28 09:05:19 PDT
Created attachment 54570 [details]
Rebaseline SVG layout tests
Comment 18 Jeremy Orlow 2010-04-28 09:06:20 PDT
Comment on attachment 54570 [details]
Rebaseline SVG layout tests

r=me  (reviewed over shoulder)
Comment 19 WebKit Commit Bot 2010-04-28 12:05:55 PDT
Comment on attachment 54570 [details]
Rebaseline SVG layout tests

Rejecting patch 54570 from commit-queue.

Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Jeremy Orlow', u'--force']" exit_code: 1
Last 500 characters of output:
patching file LayoutTests/platform/chromium-win/svg/transforms/text-with-pattern-with-svg-transform-expected.txt
patching file LayoutTests/platform/chromium-win/traversal/node-iterator-prototype-expected.txt
patching file LayoutTests/platform/chromium/test_expectations.txt
Hunk #1 FAILED at 2799.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/chromium/test_expectations.txt.rej

Full output: http://webkit-commit-queue.appspot.com/results/1906076
Comment 20 Yaar Schnitman 2010-04-29 16:25:34 PDT
There are missing expectations:
Comment 21 Eric Seidel (no email) 2010-05-17 01:49:03 PDT
Unsure as to the status of this bug.  Was it eventually landed?
Comment 22 Nikolas Zimmermann 2010-07-09 07:24:22 PDT
Changed component to SVG, so it shows up in my all-svg-bugs search.
Comment 23 Adam Barth 2010-08-10 22:23:06 PDT
I'm assuming this was fixed since it's super old.