In the following tests, the caret moved a pixel over. I'm not certain if this is expected, so I haven't rebaselined the tests yet. This is failing for me on WebKit mac and the chromium ports. I will mark the tests as expected to fail for now (if we update the mac pixel results first, we won't need to rebaseline all of these for chromium). editing/deleting/4845371.html = IMAGE editing/deleting/5126166.html = IMAGE editing/deleting/5483370.html = IMAGE editing/deleting/table-cells.html = IMAGE editing/inserting/4875189-2.html = IMAGE editing/pasteboard/5387578.html = IMAGE editing/pasteboard/paste-4039777-fix.html = IMAGE editing/pasteboard/paste-table-001.html = IMAGE editing/pasteboard/paste-table-cells.html = IMAGE editing/selection/move-past-trailing-space.html = IMAGE fast/inline-block/14498-positionForCoordinates.html = IMAGE fast/repaint/caret-outside-block.html = IMAGE
Created attachment 54260 [details] Patch
Committed r58234: <http://trac.webkit.org/changeset/58234>
Created attachment 54322 [details] mac pixel test result obsolete patch already committed patch 54260. What is the process for updating pixel test results under chromium-linux, chromium-win, and chromium-mac if any? Should I run the test manually in chromium in 3 platforms and copy the results over to webkit tree? Or is there any automatic way?
(In reply to comment #3) > Created an attachment (id=54322) [details] > mac pixel test result > > obsolete patch already committed patch 54260. > > What is the process for updating pixel test results under chromium-linux, > chromium-win, and chromium-mac if any? > Should I run the test manually in chromium in 3 platforms and copy the results > over to webkit tree? > Or is there any automatic way? Use the rebaseline tool for Chromium results: https://trac.webkit.org/wiki/Rebaseline
Created attachment 54573 [details] patch for webkit Mac and chromium pixel test results
Comment on attachment 54573 [details] patch for webkit Mac and chromium pixel test results ok.
Comment on attachment 54573 [details] patch for webkit Mac and chromium pixel test results Rejecting patch 54573 from commit-queue. xji@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in WebKitTools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). Due to bug 30084 the commit-queue will require a restart after your change. Please contact eseidel@chromium.org to request a commit-queue restart. After restart the commit-queue will correctly respect your committer rights.
Committed r58415: <http://trac.webkit.org/changeset/58415>
The patch is actually committed in r58414: <http://trac.webkit.org/changeset/58414> Since I forgot to include the bug id in the ChangeLog, I cancelled landing, and re-land it, which caused the wrong/duplicated information in r58415 ChangeLog.