RESOLVED FIXED Bug 38103
[DRT/Chromium] Enable Windows project generation 
https://bugs.webkit.org/show_bug.cgi?id=38103
Summary [DRT/Chromium] Enable Windows project generation
Kent Tamura
Reported 2010-04-25 23:24:30 PDT
[DRT/Chromium] Enable Windows project generation
Attachments
Proposed patch (2.31 KB, patch)
2010-04-25 23:29 PDT, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Proposed patch (rev.2) (2.31 KB, patch)
2010-04-25 23:33 PDT, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tony Chang
Comment 1 2010-04-25 23:28:17 PDT
On my machine, I just switched from system.Platform() to sys.platform. Also, roland says that on Windows 7 system.Platform() works, so the crash in system.Platform() might be Vista specific.
Kent Tamura
Comment 2 2010-04-25 23:29:18 PDT
Created attachment 54258 [details] Proposed patch
Tony Chang
Comment 3 2010-04-25 23:30:39 PDT
Comment on attachment 54258 [details] Proposed patch WebKit/chromium/gyp_webkit:80 + if sys.platform == 'Linux2': Nit: I think this has to be lowercase to match. Otherwise, LGTM.
Kent Tamura
Comment 4 2010-04-25 23:33:30 PDT
Created attachment 54259 [details] Proposed patch (rev.2)
Kent Tamura
Comment 5 2010-04-25 23:34:11 PDT
(In reply to comment #3) > + if sys.platform == 'Linux2': > Nit: I think this has to be lowercase to match. You're right! Fixed.
Shinichiro Hamaji
Comment 6 2010-04-25 23:46:56 PDT
Comment on attachment 54259 [details] Proposed patch (rev.2) rs=me as per Tony's LGTM.
Kent Tamura
Comment 7 2010-04-26 00:33:55 PDT
Comment on attachment 54259 [details] Proposed patch (rev.2) Clearing flags on attachment: 54259 Committed r58237: <http://trac.webkit.org/changeset/58237>
Kent Tamura
Comment 8 2010-04-26 00:34:05 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 9 2010-04-26 00:44:43 PDT
http://trac.webkit.org/changeset/58237 might have broken Chromium Linux Release
Kent Tamura
Comment 10 2010-04-26 01:29:59 PDT
Reopened because I rolled out r58237. Probably Chromium/Linux bot should have libglu1-mesa-dev, or Chromium code should use third_party/mesa/.
Kent Tamura
Comment 11 2010-04-27 18:06:05 PDT
Dimitri kindly updated packages on Chromium Linux bot. I'll commit the patch again.
Kent Tamura
Comment 12 2010-04-27 21:49:33 PDT
(In reply to comment #11) > Dimitri kindly updated packages on Chromium Linux bot. > I'll commit the patch again. r58341 already bumped the Chromium revision to r45696. I'll commit only the gyp_webkit and ChangeLog changes.
Kent Tamura
Comment 13 2010-04-27 21:53:39 PDT
Committed r58377: <http://trac.webkit.org/changeset/58377>
Note You need to log in before you can comment on or make changes to this bug.