Bug 38091 – Build error without geolocation

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[ojab]

CXXLD  libwebkit-1.0.la
/bin/mkdir -p ./.deps/DerivedSources
  CC     WebKitTools/GtkLauncher/Programs_GtkLauncher-main.o
  CCLD   Programs/GtkLauncher
./.libs/libwebkit-1.0.so: undefined reference to `WebCore::Geolocation::clearWatch(int)'
collect2: ld returned 1 exit status
make[1]: *** [Programs/GtkLauncher] Error 1
make[1]: Leaving directory `/sources/WebKit/WebKitBuild/Release'
make: *** [all] Error 2

[Ryuan Choi]

Created attachment 54237 [details]
Fixing build break when Geolocation feature is disabled

Can I fix this build break?
I am newbie in webkit.org

My modification is as below,

Index: WebCore/page/Geolocation.cpp
===================================================================
--- WebCore/page/Geolocation.cpp        (revision 58227)
+++ WebCore/page/Geolocation.cpp        (working copy)
@@ -659,6 +659,8 @@ void Geolocation::stopUpdating()

 namespace WebCore {

+void Geolocation::clearWatch(int watchId) {}
+

I think clearWatch() should be added to #else of ENABLE(GEOLOCATION) in Geolocation.cpp

Thank you,
Ryuan Choi

[Laszlo Gombos]

Some of these are addresses in bug 25756. At least for the QtWebKit port this change is not needed. Where is call site for clearWatch if ENABLE(GEOLOCATION) is turned of ?

[Eric Seidel (no email)]

Comment on attachment 54237 [details]
Fixing build break when Geolocation feature is disabled

No new tests. (OOPS!)
should be replaced with a statement as to why there are no tests.  In this case, it's rather obvious, this is a build fix only.

The "Reviewed by NOBODY (OOPS!)." line will automatically get updated by the commit-queue or webkit-patch or however this patch is landed.

[Ryuan Choi]

Created attachment 54433 [details]
fix ChangeLog

Thank you for answer, Eric. I fixed Changelog

and I saw this build break in gtk port.

[Eric Seidel (no email)]

Comment on attachment 54237 [details]
Fixing build break when Geolocation feature is disabled

Please obsolete your old patches when posting a new one.

webkit-patch upload
will automate the entire process of posting a patch for you. :)

[Ryuan Choi]

Created attachment 54922 [details]
Patch

[Ryuan Choi]

hmm. sorry I missed --no-obsolete option

and I had some issues about LANG.
(I use ko_KR.UTF-8)

anyway, Thank you for your kindness.

[WebKit Commit Bot]

Comment on attachment 54922 [details]
Patch

Clearing flags on attachment: 54922

Committed r58682: <http://trac.webkit.org/changeset/58682>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Nayan]

*** Bug 38451 has been marked as a duplicate of this bug. ***