RESOLVED FIXED 38088
Null characters handled incorrectly in ToNumber conversion 
https://bugs.webkit.org/show_bug.cgi?id=38088
Summary Null characters handled incorrectly in ToNumber conversion
Darin Adler
Reported 2010-04-24 22:53:38 PDT
Null characters handled incorrectly in ToNumber conversion
Attachments
Patch (9.05 KB, patch)
2010-04-25 21:56 PDT, Darin Adler 		tkent: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2010-04-25 21:56:11 PDT
Created attachment 54254 [details] Patch
Eric Seidel (no email)
Comment 2 2010-05-02 19:00:20 PDT
Comment on attachment 54254 [details] Patch Can't we demonstrate the thread-safety failure with a workers-based test? I wonder if this explains any worker crashes seen on the bots.
Darin Adler
Comment 3 2010-05-02 23:39:49 PDT
(In reply to comment #2) > Can't we demonstrate the thread-safety failure with a workers-based test? Perhaps. I don't know. > I wonder if this explains any worker crashes seen on the bots. Maybe.
Darin Adler
Comment 4 2010-05-02 23:40:44 PDT
(In reply to comment #2) > I wonder if this explains any worker crashes seen on the bots. Probably not. This code path is only used for numeric conversions that overflow in a particular way.
Kent Tamura
Comment 5 2010-05-26 03:02:52 PDT
Comment on attachment 54254 [details] Patch This looks OK. We should have UChar versions of strtod() and dtoa().
Darin Adler
Comment 6 2010-05-27 16:10:16 PDT
Committed r60328: <http://trac.webkit.org/changeset/60328>
Note You need to log in before you can comment on or make changes to this bug.