RESOLVED WONTFIX 38057
Refactor the test for "using" 
https://bugs.webkit.org/show_bug.cgi?id=38057
Summary Refactor the test for "using"
Laszlo Gombos
Reported 2010-04-23 13:42:23 PDT
Compile time tests like the following break easily and hard to see what they actually do - this is a quest to find a better test for the following: #if !COMPILER(MSVC) && !COMPILER(WINSCW) && !(COMPILER(RVCT) && OS(SYMBIAN))
Attachments
Change the test to COMPILER(GCC) (1.09 KB, patch)
2010-04-23 13:46 PDT, Laszlo Gombos 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Laszlo Gombos
Comment 1 2010-04-23 13:46:56 PDT
Created attachment 54189 [details] Change the test to COMPILER(GCC) It seems to me that GCC is the only environment where this works. Anybody knows about an environment where this test is not good enough ?
Gabor Loki
Comment 2 2010-04-23 15:25:13 PDT
-#if !COMPILER(MSVC) && !COMPILER(WINSCW) && !(COMPILER(RVCT) && OS(SYMBIAN)) +#if COMPILER(GCC) Hmm, it looks like the results of the conditions are different. For example, you missed the RVCT and Linux pair.
Darin Adler
Comment 3 2010-04-24 09:40:12 PDT
The "using" code path is the standard-compliant one. So even if GCC is the only compiler that currently gets this right, it seems backwards to write the condition assuming that will be true in the future. Instead we should list the other compilers.
Laszlo Gombos
Comment 4 2010-04-26 09:29:04 PDT
Based on the feedback I mark this WONTFIX, please reopen if you have a better proposal deal with this problem.
Note You need to log in before you can comment on or make changes to this bug.