Android is failing the basic-single-touch-events test due to an optimisation in the Android framework that does not forward touch events to WebCore if they are a small move. Currently the delta used in the singleTouchSequence function in basic-single-touch-events (10, 10) -> (20, 15) falls within the scope of the optimisation and so we fail the test as the touch event is not sent to WebCore. I'd like to propose increasing this delta so that the test passes on Android. Proposed patch to follow.
Created attachment 54181 [details] Proposed Patch
Comment on attachment 54181 [details] Proposed Patch Might it be a good idea to change one of the values so that they're not both 50 and/or 20?
(In reply to comment #2) > (From update of attachment 54181 [details]) > Might it be a good idea to change one of the values so that they're not both 50 > and/or 20? I could do ... although all the analysis I've done I've always looked at the x and y as a pair, so it was only useful to make the x,y pair distinct from other pairs. Unless you feel strongly I think we can just leave as-is. Thanks, Ben
I r+'ed it because I was OK with it in its current state. Just a suggestion.
Comment on attachment 54181 [details] Proposed Patch Great, thanks. Setting cq+.
Comment on attachment 54181 [details] Proposed Patch Clearing flags on attachment: 54181 Committed r58208: <http://trac.webkit.org/changeset/58208>
All reviewed patches have been landed. Closing bug.