Bug 38051 – [GTK] Fix out of source build failure

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Geoff Levand]

Add a preprocessor include path for generated GTK header files.
Fixes build errors like these when building GTK out of source:

  webkit.h: error: webkit/webkitversion.h: No such file or directory

-Geoff

[Geoff Levand]

Created attachment 54171 [details]
patch v1

[Geoff Levand]

Created attachment 54176 [details]
patch v2

[WebKit Review Bot]

Attachment 54176 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
Total errors found: 0 in 0 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Geoff Levand]

Created attachment 54177 [details]
patch v3

[WebKit Review Bot]

Attachment 54177 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
Total errors found: 0 in 0 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Geoff Levand]

Created attachment 54178 [details]
patch v4

[Eric Seidel (no email)]

Comment on attachment 54178 [details]
patch v4

OK...  rs=me.

[Eric Seidel (no email)]

Comment on attachment 54178 [details]
patch v4

I think what you all are actually looking for is forwarding headers.  See WebCore/ForwardingHeaders as examples.  Or at least that's how this sort of problem of internal header paths vs. external header paths are solved on Mac.  But this looks OK too.

[WebKit Commit Bot]

Comment on attachment 54178 [details]
patch v4

Clearing flags on attachment: 54178

Committed r58664: <http://trac.webkit.org/changeset/58664>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Xan Lopez]

(In reply to comment #0)
> Add a preprocessor include path for generated GTK header files.
> Fixes build errors like these when building GTK out of source:
> 
>   webkit.h: error: webkit/webkitversion.h: No such file or directory
> 
> -Geoff

When you say out of source you simply mean using a build directory like WebKitBuild? It's strange that you say it does not work for you, since we all use that every day. What is your environment like exactly?

[Geoff Levand]

Hi,

(In reply to comment #11)
> (In reply to comment #0)
> > Add a preprocessor include path for generated GTK header files.
> > Fixes build errors like these when building GTK out of source:
> > 
> >   webkit.h: error: webkit/webkitversion.h: No such file or directory
> 
> When you say out of source you simply mean using a build directory like
> WebKitBuild? It's strange that you say it does not work for you, since we all
> use that every day. What is your environment like exactly?

This is a common automake makefile bug.  Something like this
will hit it:

git clone git://git.webkit.org/WebKit.git
cd WebKit
./autogen.sh
mkdir ../build
cd ../build
../Webkit/configure
make

-Geoff

[Xan Lopez]

(In reply to comment #12)
> This is a common automake makefile bug.  Something like this
> will hit it:
> 
> git clone git://git.webkit.org/WebKit.git
> cd WebKit
> ./autogen.sh
> mkdir ../build
> cd ../build
> ../Webkit/configure
> make
> 
> -Geoff

Yeah, we all use something like that and this is the first time I hear from anyone of a build failure. That's why I was wondering of the exact details of your environment.