Bug 38043 - Web Inspector: Profiler: A status item is required when record button is pressed.
Summary: Web Inspector: Profiler: A status item is required when record button is pres...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Mikhail Naganov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-23 05:01 PDT by Ilya Tikhonovsky
Modified: 2010-05-04 03:04 PDT (History)
4 users (show)

See Also:

Attachments
proposed patch (3.86 KB, patch)
2010-04-30 04:49 PDT, Mikhail Naganov 		pfeldman: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2010-04-23 05:01:47 PDT 
%SUBJ%
Comment 1 Mikhail Naganov 2010-04-30 04:49:11 PDT 
Created attachment 54793 [details]
proposed patch
Comment 2 Pavel Feldman 2010-04-30 07:56:27 PDT 
Comment on attachment 54793 [details]
proposed patch

WebCore/inspector/front-end/ProfilesPanel.js:328
 +              if (this._profiles[i].uid == profile.uid) {
=== ?
Comment 3 Mikhail Naganov 2010-05-04 03:04:44 PDT 
Manually committed as http://trac.webkit.org/changeset/58745.

2010-05-04  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        Display "Recording..." item when recording an user-initiated CPU profile.

        https://bugs.webkit.org/show_bug.cgi?id=38043

        * English.lproj/localizedStrings.js:
        * inspector/front-end/ProfilesPanel.js:
        (WebInspector.ProfilesPanel.prototype.addProfileHeader):
        (WebInspector.ProfilesPanel.prototype.removeProfileHeader):
        (WebInspector.ProfilesPanel.prototype.showProfile):
        * inspector/front-end/inspector.js:
        (WebInspector.setRecordingProfile):