Bug 38037 - remove 'with' from http_server.py
Summary: remove 'with' from http_server.py
Status: RESOLVED DUPLICATE of bug 38031
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-23 01:14 PDT by Tony Chang
Modified: 2010-04-23 02:06 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.31 KB, patch)
2010-04-23 01:14 PDT, Tony Chang 		no flags Details | Formatted Diff | Diff
Patch (10.50 KB, patch)
2010-04-23 01:41 PDT, Tony Chang 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2010-04-23 01:14:02 PDT 
remove 'with' from http_server.py
Comment 1 Tony Chang 2010-04-23 01:14:51 PDT 
Created attachment 54138 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-04-23 01:31:17 PDT 
Comment on attachment 54138 [details]
Patch

Looks good to me.  Thanks for fixing.
Comment 3 Tony Chang 2010-04-23 01:41:49 PDT 
Created attachment 54139 [details]
Patch
Comment 4 Eric Seidel (no email) 2010-04-23 01:46:28 PDT 
Comment on attachment 54139 [details]
Patch

I think this is a dangerous road we shouldn't really go down. I'm in favor of unhinging these issues.  But given this number of changes these bots are guarenteed to break again days from now.  How much work is it to upgrade them?  I thought all was needed to upgrade folks was to have them re-run glient after deleting some file?  Dirk posted instructions on chromium-dev at some point.
Comment 5 Tony Chang 2010-04-23 02:06:20 PDT 
Moving the patch over since this should be on bug 38031

*** This bug has been marked as a duplicate of bug 38031 ***