Bug 38028 - [chromium] build-webkit --chromium should build release by default
Summary: [chromium] build-webkit --chromium should build release by default
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-22 20:42 PDT by Tony Chang
Modified: 2010-04-26 18:27 PDT (History)
1 user (show)

See Also:

Attachments
Patch (2.74 KB, patch)
2010-04-22 20:43 PDT, Tony Chang 		no flags Details | Formatted Diff | Diff
Patch (2.51 KB, patch)
2010-04-23 00:37 PDT, Tony Chang 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2010-04-22 20:42:13 PDT 
[chromium] build-webkit --chromium should build release by default
Comment 1 Tony Chang 2010-04-22 20:43:39 PDT 
Created attachment 54125 [details]
Patch
Comment 2 Adam Barth 2010-04-23 00:33:32 PDT 
Comment on attachment 54125 [details]
Patch

WebKitTools/Scripts/webkitdirs.pm: 
 +  
Why remove this random line?

I don't read perl, but this looks plausible.  Leaving it for a perl hacker though.
Comment 3 Tony Chang 2010-04-23 00:34:39 PDT 
(In reply to comment #2)
> (From update of attachment 54125 [details])
> WebKitTools/Scripts/webkitdirs.pm: 
>  +  
> Why remove this random line?

Oops, that's an accident.
Comment 4 Tony Chang 2010-04-23 00:37:03 PDT 
Created attachment 54137 [details]
Patch
Comment 5 David Levin 2010-04-26 17:31:21 PDT 
Why does this only change the Chromium OSX builds (and not the Windows or Linux builds)?
Comment 6 Tony Chang 2010-04-26 17:47:13 PDT 
(In reply to comment #5)
> Why does this only change the Chromium OSX builds (and not the Windows or Linux
> builds)?

Windows and Linux already do the right thing in buildChromiumMakefile and buildChromiumVisualStudioProject.
Comment 7 Tony Chang 2010-04-26 18:27:06 PDT 
Comment on attachment 54137 [details]
Patch

Clearing flags on attachment: 54137

Committed r58275: <http://trac.webkit.org/changeset/58275>
Comment 8 Tony Chang 2010-04-26 18:27:15 PDT 
All reviewed patches have been landed.  Closing bug.