Bug 38026 - [Qt] Disable Netscape plugin support for minimal configuration
Summary: [Qt] Disable Netscape plugin support for minimal configuration
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt
Depends on:
Blocks:
 
Reported: 2010-04-22 20:12 PDT by Laszlo Gombos
Modified: 2010-04-23 14:06 PDT (History)
4 users (show)

See Also:


Attachments
proposed patch (2.22 KB, patch)
2010-04-22 20:27 PDT, Laszlo Gombos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Gombos 2010-04-22 20:12:01 PDT
Now that we have a "minimal" buildbot for QtWebKit and NPAPI-less configuration is often broken, it could be a real win to disable NPAPI for minimal configuration so that we get an immediate build-break.
Comment 1 Laszlo Gombos 2010-04-22 20:27:10 PDT
Created attachment 54124 [details]
proposed patch

This patch make the minimal configuration option visible in the Qt make system, which could be useful later as well.

An alternative to this patch is to create a global "npapi support" build option to build-webkit, but as many ports do not support this option,I felt it is best to do it for the Qt port only.
Comment 2 WebKit Commit Bot 2010-04-23 11:31:48 PDT
Comment on attachment 54124 [details]
proposed patch

Clearing flags on attachment: 54124

Committed r58178: <http://trac.webkit.org/changeset/58178>
Comment 3 WebKit Commit Bot 2010-04-23 11:31:54 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 WebKit Review Bot 2010-04-23 11:43:42 PDT
http://trac.webkit.org/changeset/58178 might have broken Qt Linux Release minimal
Comment 5 Tor Arne Vestbø 2010-04-23 12:14:13 PDT
Any reason you didn't add it as a normal enable/disable option to build-webkit so that the --minimal option would do this automatically?
Comment 6 Tor Arne Vestbø 2010-04-23 12:17:14 PDT
(In reply to comment #1)
> An alternative to this patch is to create a global "npapi support" build option
> to build-webkit, but as many ports do not support this option,I felt it is best
> to do it for the Qt port only.

Never mind, didn't see this comment. If we can I'd rather we move this to a global option if possible.
Comment 7 Laszlo Gombos 2010-04-23 14:06:52 PDT
(In reply to comment #4)
> http://trac.webkit.org/changeset/58178 might have broken Qt Linux Release
> minimal

Dependency problems with the bot, bug filed - bug 38054