We've gotten all the feedback we're going to get without moving forward. So, I think we should take the next steps. Some options: 1. Make --fancy-review the default. Pro: People who have the chrome extension installed and start doing real reviews and find the bugs. Con: Upload takes longer 2. Move the extension code into bugzilla. 3. Make upload put the rietveld issue in the ChangeLog so we can upload to the same issue instead of creating a new one each time. Ideally we'd start working on all three of these immediately. 1 is the simplest. I volunteer to do that assuming there are no objections. Once we've done 1, that will let us get a better sense of what the outstanding issues are with the upload/reitveld process. Sound OK?
Sounds good to me.
Created attachment 54319 [details] Patch-11001
I'm not sure I like that this is going to put rietveld bug review links in every bug I upload.
(In reply to comment #3) > I'm not sure I like that this is going to put rietveld bug review links in > every bug I upload. All it does is append the rietveld issue id to the patch description. It only shows a rietveld review link if you have the chrome extension installed. It no longer appends a review link to the bug comments, ever.
Note that I uploaded this patch using --fancy-review, so this bug is a good example of what will change (i.e. very little).
Comment on attachment 54319 [details] Patch-11001 Woh, ok. We probably need to change the description name slightly.
Committed r58265: <http://trac.webkit.org/changeset/58265>
Filed bug 38143 and bug 38144 for items 2 and 3 above.
Reverted r58265 for reason: This change prevents me from uploading patches Committed r58282: <http://trac.webkit.org/changeset/58282>
http://trac.webkit.org/changeset/58282 might have broken SnowLeopard Intel Release (Tests) The following changes are on the blame list: http://trac.webkit.org/changeset/58281 http://trac.webkit.org/changeset/58282
(In reply to comment #9) > This change prevents me from uploading patches Ugh. Sorry this broke you. What was the error you were getting? Also, how did it break sheriffbot?
Attachment 54319 [details] was posted by a committer and has review+, assigning to Ojan Vafai for commit.
Comment on attachment 54319 [details] Patch-11001 This has been committed and rolled back.
This is obsolete. The rietveld work is going on in different patches.