Bug 38017 - CompositeAnimation::updateKeyframeAnimations() can make a KeyframeAnimation for animation "none"
Summary: CompositeAnimation::updateKeyframeAnimations() can make a KeyframeAnimation f...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All OS X 10.5
: P2 Normal
Assignee: Chris Marrin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-22 17:50 PDT by Simon Fraser (smfr)
Modified: 2010-04-23 13:23 PDT (History)
0 users

See Also:


Attachments
Patch (2.08 KB, patch)
2010-04-23 09:49 PDT, Simon Fraser (smfr)
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2010-04-22 17:50:09 PDT
Code ni CompositeAnimation::updateKeyframeAnimations() makes KeyframeAnimation objects when the animation-name is "none" (which explicitly should not animate anything).
Comment 1 Simon Fraser (smfr) 2010-04-23 09:49:11 PDT
Created attachment 54169 [details]
Patch
Comment 2 mitz 2010-04-23 11:04:08 PDT
Comment on attachment 54169 [details]
Patch

You could add an explanation for the lack of a regression test.
Comment 3 Simon Fraser (smfr) 2010-04-23 13:23:24 PDT
http://trac.webkit.org/changeset/58185