Bug 38002 - Add rudimentary statistics gathering for WebKit2
Summary: Add rudimentary statistics gathering for WebKit2
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-22 13:18 PDT by Sam Weinig
Modified: 2010-04-23 21:06 PDT (History)
2 users (show)

See Also:

Attachments
patch (42.23 KB, patch)
2010-04-22 13:20 PDT, Sam Weinig 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2010-04-22 13:18:16 PDT 
Add rudimentary statistics gathering for WebKit2 and some MiniBrowser hacking to show it off.
Comment 1 Sam Weinig 2010-04-22 13:20:20 PDT 
Created attachment 54090 [details]
patch
Comment 2 WebKit Review Bot 2010-04-22 13:26:51 PDT 
Attachment 54090 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/UIProcess/WebPageProxy.cpp:43:  Alphabetical sorting problem.  [build/include_order] [4]
WebKit2/UIProcess/WebPageNamespace.cpp:31:  Alphabetical sorting problem.  [build/include_order] [4]
WebKit2/UIProcess/WebContext.cpp:33:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 3 in 21 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Anders Carlsson 2010-04-22 13:54:57 PDT 
Comment on attachment 54090 [details]
patch

r=me
Comment 4 Sam Weinig 2010-04-22 13:57:16 PDT 
Fixed in r58117.
Comment 5 Adam Barth 2010-04-23 18:32:38 PDT 
Did these style errors get addressed before landing?  Are the errors false positives?
Comment 6 Sam Weinig 2010-04-23 21:06:11 PDT 
(In reply to comment #5)
> Did these style errors get addressed before landing?  Are the errors false
> positives?

The issue is that I am paragraphing the #includes, so the script is a little confused.  I don't think we have a style rule for this, and it is perhaps something I just should not be doing.