Bug 37997 - [EFL] Update EWebKit to match recent API changes
Summary: [EFL] Update EWebKit to match recent API changes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-22 10:51 PDT by Leandro Pereira
Modified: 2010-04-22 15:41 PDT (History)
1 user (show)

See Also:


Attachments
Update ewk to match recent API changes (5.26 KB, patch)
2010-04-22 10:51 PDT, Leandro Pereira
gns: review-
Details | Formatted Diff | Diff
Update ewk to match recent API changes (5.79 KB, patch)
2010-04-22 11:14 PDT, Leandro Pereira
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Leandro Pereira 2010-04-22 10:51:00 PDT
Attached patch updates EWebKit files to match recent API changes.
Comment 1 Leandro Pereira 2010-04-22 10:51:52 PDT
Created attachment 54074 [details]
Update ewk to match recent API changes
Comment 2 Gustavo Noronha (kov) 2010-04-22 11:01:49 PDT
Comment on attachment 54074 [details]
Update ewk to match recent API changes

 1845 #if 0
18361846     WTF::RefPtr<WebCore::PluginView> pluginView = WebCore::PluginView::create
18371847         (sd->frame, pluginSize, element, url, paramNames, paramValues,
18381848          mimeType, loadManually);
18391849 
18401850     if (pluginView->status() == WebCore::PluginStatusLoadedSuccessfully)
18411851         return pluginView;
 1852 #endif
18421853 

It's not usual to have code ifdefed/commented out in WebKit, and it looks like this change should go separately?

991      sd->frame->setZoomFactor(zoom, sd->zoom_text_only);
 991     WebCore::ZoomMode zoomMode;
 992     if (sd->zoom_text_only)
 993         zoomMode = WebCore::ZoomTextOnly;
 994     else
 995         zoomMode = WebCore::ZoomPage;
 996     sd->frame->setZoomFactor(zoom, zoomMode);

Just to be clear, this was WebCore going from boolean to an enum?

r- because of the first issue
Comment 3 Leandro Pereira 2010-04-22 11:09:56 PDT
(In reply to comment #2)
> 
> Just to be clear, this was WebCore going from boolean to an enum?
> 

Exactly.
Comment 4 Leandro Pereira 2010-04-22 11:14:24 PDT
Created attachment 54077 [details]
Update ewk to match recent API changes

Updated patch that fixes the commented-out code pointed by gns.
Comment 5 Gustavo Noronha (kov) 2010-04-22 11:17:42 PDT
Comment on attachment 54077 [details]
Update ewk to match recent API changes

OK, I'm sure situation will improve when you have enough to get a bot running =)
Comment 6 WebKit Commit Bot 2010-04-22 15:41:42 PDT
Comment on attachment 54077 [details]
Update ewk to match recent API changes

Clearing flags on attachment: 54077

Committed r58121: <http://trac.webkit.org/changeset/58121>
Comment 7 WebKit Commit Bot 2010-04-22 15:41:47 PDT
All reviewed patches have been landed.  Closing bug.