Attached patch updates EWebKit files to match recent API changes.
Created attachment 54074 [details] Update ewk to match recent API changes
Comment on attachment 54074 [details] Update ewk to match recent API changes 1845 #if 0 18361846 WTF::RefPtr<WebCore::PluginView> pluginView = WebCore::PluginView::create 18371847 (sd->frame, pluginSize, element, url, paramNames, paramValues, 18381848 mimeType, loadManually); 18391849 18401850 if (pluginView->status() == WebCore::PluginStatusLoadedSuccessfully) 18411851 return pluginView; 1852 #endif 18421853 It's not usual to have code ifdefed/commented out in WebKit, and it looks like this change should go separately? 991 sd->frame->setZoomFactor(zoom, sd->zoom_text_only); 991 WebCore::ZoomMode zoomMode; 992 if (sd->zoom_text_only) 993 zoomMode = WebCore::ZoomTextOnly; 994 else 995 zoomMode = WebCore::ZoomPage; 996 sd->frame->setZoomFactor(zoom, zoomMode); Just to be clear, this was WebCore going from boolean to an enum? r- because of the first issue
(In reply to comment #2) > > Just to be clear, this was WebCore going from boolean to an enum? > Exactly.
Created attachment 54077 [details] Update ewk to match recent API changes Updated patch that fixes the commented-out code pointed by gns.
Comment on attachment 54077 [details] Update ewk to match recent API changes OK, I'm sure situation will improve when you have enough to get a bot running =)
Comment on attachment 54077 [details] Update ewk to match recent API changes Clearing flags on attachment: 54077 Committed r58121: <http://trac.webkit.org/changeset/58121>
All reviewed patches have been landed. Closing bug.