Bug 37991 – Do not pause movie when readyState drops below HAVE_FUTURE_DATA

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Eric Carlson]

HTMLMediaElement currently calls m_player->pause() when playback stops because the media engine runs out of buffered data. This is unnecessary for downloaded movies because the movie is already "paused", and is harmful for streamed movies because no data is loaded once paused.

[Eric Carlson]

<rdar://problem/7893937>

[Eric Carlson]

Created attachment 54066 [details]
Proposed patch

[Simon Fraser (smfr)]

Comment on attachment 54066 [details]
Proposed patch


>  bool HTMLMediaElement::potentiallyPlaying() const
>  {
> -    return m_readyState >= HAVE_FUTURE_DATA && couldPlayIfEnoughData();
> +    bool pausedToBuffer = m_readyStateMaximum >= HAVE_FUTURE_DATA && m_readyState < HAVE_FUTURE_DATA;
> +    return (pausedToBuffer || m_readyState >= HAVE_FUTURE_DATA) && couldPlayIfEnoughData();

I think a comment here would be useful, to explain exactly what pausedToBuffer means.

[Eric Carlson]

trac.webkit.org/changeset/58107

[WebKit Review Bot]

http://trac.webkit.org/changeset/58107 might have broken Leopard Intel Release (Tests)

[Eric Seidel (no email)]

Yup.  Looks like this broke Tiger and Leopard test machines:
http://build.webkit.org/results/Leopard%20Intel%20Debug%20(Tests)/r58107%20(13331)/results.html

[Eric Carlson]

I am looking into it.

[Eric Carlson]

Looks like this change has exposed a QuickTime/QTKit bug. Continuing to dig.

[Eric Carlson]

Will need to spend some quality time in QuickTime to figure this out, so these tests added to the Leopard and Tiger skipped lists in http://trac.webkit.org/changeset/58109