Bug 37983 – Add RVCT support for Linux

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Gabor Rapcsanyi]

Created attachment 54044 [details]
Add RVCT support for Linux

Add defines and JIT function needed to build WebKit with RVCT on Linux.

[WebKit Review Bot]

Attachment 54044 [details] did not build on gtk:
Build output: http://webkit-commit-queue.appspot.com/results/1787041

[Gabor Rapcsanyi]

Created attachment 54053 [details]
Add RVCT support for Linux v2

[Laszlo Gombos]

Comment on attachment 54053 [details]
Add RVCT support for Linux v2

Looks good to me, except one merge conflict that needs to be addressed.

> diff --git a/JavaScriptCore/wtf/MathExtras.h b/JavaScriptCore/wtf/MathExtras.h
> index a0c7466..2bf2dd3 100644
> --- a/JavaScriptCore/wtf/MathExtras.h
> +++ b/JavaScriptCore/wtf/MathExtras.h
> @@ -188,7 +188,7 @@ inline float deg2turn(float d) { return d / 360.0f; }
>  inline float rad2grad(float r) { return r * 200.0f / piFloat; }
>  inline float grad2rad(float g) { return g * piFloat / 200.0f; }
>  
> -#if !COMPILER(MSVC) && !COMPILER(RVCT) && !OS(ANDROID) && !COMPILER(WINSCW)
> +#if !COMPILER(MSVC) && !OS(ANDROID) && !COMPILER(WINSCW) && !(COMPILER(RVCT) && OS(SYMBIAN))
>  using std::isfinite;
>  using std::isinf;
>  using std::isnan;

!OS(ANDROID) test has been removed - see http://trac.webkit.org/changeset/58142.

r-, just to make this small change.

[Gabor Rapcsanyi]

Created attachment 54157 [details]
Add RVCT support for Linux v3

[Laszlo Gombos]

Comment on attachment 54157 [details]
Add RVCT support for Linux v3

Great patch, thanks. LGTM, r+.

[WebKit Commit Bot]

Comment on attachment 54157 [details]
Add RVCT support for Linux v3

Clearing flags on attachment: 54157

Committed r58167: <http://trac.webkit.org/changeset/58167>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.