Bug 37979 - [chromium] fix ImageDiff compile on windows
Summary: [chromium] fix ImageDiff compile on windows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-22 00:36 PDT by Tony Chang
Modified: 2010-04-22 01:04 PDT (History)
0 users

See Also:


Attachments
Patch (1.06 KB, patch)
2010-04-22 00:36 PDT, Tony Chang
no flags Details | Formatted Diff | Diff
Patch (1.05 KB, patch)
2010-04-22 01:00 PDT, Tony Chang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2010-04-22 00:36:17 PDT
[chromium] fix ImageDiff compile on windows
Comment 1 Tony Chang 2010-04-22 00:36:41 PDT
Created attachment 54035 [details]
Patch
Comment 2 Kent Tamura 2010-04-22 00:55:05 PDT
Comment on attachment 54035 [details]
Patch

This is a build fix.  So I think we may commit it without review.

> --- a/WebKitTools/DumpRenderTree/chromium/ImageDiff.cpp
> +++ b/WebKitTools/DumpRenderTree/chromium/ImageDiff.cpp
> @@ -39,12 +39,15 @@
>  #include "gfx/codec/png_codec.h"
>  #include <algorithm>
>  #include <stdio.h>
> -#include <string.h>
> -#include <string>
>  #include <vector>

strcmp() is used. We had better not remove string.h.
Comment 3 Tony Chang 2010-04-22 01:00:00 PDT
Created attachment 54039 [details]
Patch
Comment 4 Tony Chang 2010-04-22 01:03:25 PDT
(In reply to comment #2)
> (From update of attachment 54035 [details])
> > --- a/WebKitTools/DumpRenderTree/chromium/ImageDiff.cpp
> > +++ b/WebKitTools/DumpRenderTree/chromium/ImageDiff.cpp
> > @@ -39,12 +39,15 @@
> >  #include "gfx/codec/png_codec.h"
> >  #include <algorithm>
> >  #include <stdio.h>
> > -#include <string.h>
> > -#include <string>
> >  #include <vector>
> 
> strcmp() is used. We had better not remove string.h.

Good catch.  Attempting to land the revised patch now.
Comment 5 Tony Chang 2010-04-22 01:04:02 PDT
Committed r58073: <http://trac.webkit.org/changeset/58073>