Bug 37963 - Regression: framebufferRenderbuffer crashes with null renderBuffer
Summary: Regression: framebufferRenderbuffer crashes with null renderBuffer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Major
Assignee: Zhenyao Mo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-21 17:24 PDT by Kenneth Russell
Modified: 2010-04-22 10:04 PDT (History)
6 users (show)

See Also:

Attachments
patch (4.78 KB, patch)
2010-04-21 17:50 PDT, Zhenyao Mo 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Russell 2010-04-21 17:24:29 PDT 
https://bugs.webkit.org/show_bug.cgi?id=35611 introduced a regression in framebufferRenderbuffer when a null renderBuffer is passed; the null pointer is dereferenced and the WebGLRenderingContext crashes.
Comment 1 Zhenyao Mo 2010-04-21 17:50:58 PDT 
Created attachment 54009 [details]
patch
Comment 2 Kenneth Russell 2010-04-21 17:55:15 PDT 
Comment on attachment 54009 [details]
patch

Looks good. Thanks for the quick fix.
Comment 3 Dimitri Glazkov (Google) 2010-04-22 09:25:07 PDT 
Comment on attachment 54009 [details]
patch

r=me.
Comment 4 WebKit Commit Bot 2010-04-22 10:04:15 PDT 
Comment on attachment 54009 [details]
patch

Clearing flags on attachment: 54009

Committed r58103: <http://trac.webkit.org/changeset/58103>
Comment 5 WebKit Commit Bot 2010-04-22 10:04:22 PDT 
All reviewed patches have been landed.  Closing bug.