RESOLVED FIXED 37948
[Android] Android should use isfinite, isinf, isnan and signbit from the std namespace 
https://bugs.webkit.org/show_bug.cgi?id=37948
Summary [Android] Android should use isfinite, isinf, isnan and signbit from the std ...
Steve Block
Reported 2010-04-21 13:42:45 PDT
http://trac.webkit.org/changeset/54388 updated MathExtras.h to use <cmath> (rather than <math.h>) which provides isfinite, isinf, isnan and signbit in the std namespace. This broke the Android build as Android's version of STL did not at the time provide these functions in the std namespace. The build was fixed with a compile guard around the using declarations in http://trac.webkit.org/changeset/54655. Android's version of STL now provides these functions in the std namespace, so we can remove the guard around the using declarations.
Attachments
Patch (1.16 KB, patch)
2010-04-21 13:46 PDT, Steve Block 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Steve Block
Comment 1 2010-04-21 13:46:08 PDT
Created attachment 53986 [details] Patch
Adam Barth
Comment 2 2010-04-22 12:44:50 PDT
Comment on attachment 53986 [details] Patch ok.
Steve Block
Comment 3 2010-04-22 12:55:51 PDT
Comment on attachment 53986 [details] Patch Clearing flags on attachment: 53986 Committed r58110: <http://trac.webkit.org/changeset/58110>
Steve Block
Comment 4 2010-04-22 12:56:00 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 5 2010-04-22 14:17:14 PDT
http://trac.webkit.org/changeset/58110 might have broken Qt Windows 32-bit Release
Adam Barth
Comment 6 2010-04-22 15:35:51 PDT
Failure persisted after rollout
Adam Barth
Comment 7 2010-04-22 15:36:06 PDT
Comment on attachment 53986 [details] Patch Relanding.
WebKit Commit Bot
Comment 8 2010-04-22 20:10:56 PDT
Comment on attachment 53986 [details] Patch Clearing flags on attachment: 53986 Committed r58142: <http://trac.webkit.org/changeset/58142>
WebKit Commit Bot
Comment 9 2010-04-22 20:11:03 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.