Bug 37941 - new-run-webkit-tests: chromium port crashes when test_shell crashes
Summary: new-run-webkit-tests: chromium port crashes when test_shell crashes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-21 12:38 PDT by Dirk Pranke
Modified: 2010-04-21 12:49 PDT (History)
2 users (show)

See Also:


Attachments
Patch (2.04 KB, patch)
2010-04-21 12:39 PDT, Dirk Pranke
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2010-04-21 12:38:32 PDT
It looks like there are cases where test_shell crashes and we attempt to communicate with it; this raises broken pipe exceptions that we fail to catch.
Comment 1 Dirk Pranke 2010-04-21 12:39:59 PDT
Created attachment 53980 [details]
Patch
Comment 2 Dimitri Glazkov (Google) 2010-04-21 12:41:05 PDT
Comment on attachment 53980 [details]
Patch

ok.
Comment 3 Dirk Pranke 2010-04-21 12:49:40 PDT
Comment on attachment 53980 [details]
Patch

Clearing flags on attachment: 53980

Committed r58005: <http://trac.webkit.org/changeset/58005>
Comment 4 Dirk Pranke 2010-04-21 12:49:45 PDT
All reviewed patches have been landed.  Closing bug.