WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
Bug 37931
Add automated tests for UserContentURLPattern
https://bugs.webkit.org/show_bug.cgi?id=37931
Summary
Add automated tests for UserContentURLPattern
Timothy Hatcher
Reported
2010-04-21 09:32:53 PDT
We need to add tests for UserContentURLPattern.
Attachments
Patch
(9.64 KB, patch)
2014-08-07 08:28 PDT
,
Carlos Garcia Campos
kling
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1
2014-08-07 08:28:45 PDT
Created
attachment 236187
[details]
Patch This path adds a unit test for UserContentURLPattern. It's only added for GTK+ for now, since I don't have a mac to deal with xcode files. I've added several FIXME comments for the things that might be bugs in the implementation.
Andreas Kling
Comment 2
2014-08-07 16:20:04 PDT
Comment on
attachment 236187
[details]
Patch Nice idea! r=me
Carlos Garcia Campos
Comment 3
2014-08-07 23:13:53 PDT
(In reply to
comment #2
)
> (From update of
attachment 236187
[details]
) > Nice idea! r=me
Thanks for the review. It would be great if someone familiar with the UserContentURLPattern could confirm if the FIXMEs I added are actual bugs or the intended behaviour, and if someone with a mac could add the test also to the xcode. Then I'll focus on fixing the FIXMEs :-)
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug