Bug 37931 - Add automated tests for UserContentURLPattern
Summary: Add automated tests for UserContentURLPattern
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 112476
  Show dependency tree / graph
 
Reported: 2010-04-21 09:32 PDT by Timothy Hatcher
Modified: 2014-08-07 23:13 PDT (History)
9 users (show)

See Also:

Attachments
Patch (9.64 KB, patch)
2014-08-07 08:28 PDT, Carlos Garcia Campos 		kling: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2010-04-21 09:32:53 PDT 
We need to add tests for UserContentURLPattern.
Comment 1 Carlos Garcia Campos 2014-08-07 08:28:45 PDT 
Created attachment 236187 [details]
Patch

This path adds a unit test for UserContentURLPattern. It's only added for GTK+ for now, since I don't have a mac to deal with xcode files. I've added several FIXME comments for the things that might be bugs in the implementation.
Comment 2 Andreas Kling 2014-08-07 16:20:04 PDT 
Comment on attachment 236187 [details]
Patch

Nice idea! r=me
Comment 3 Carlos Garcia Campos 2014-08-07 23:13:53 PDT 
(In reply to comment #2)
> (From update of attachment 236187 [details])
> Nice idea! r=me

Thanks for the review. It would be great if someone familiar with the UserContentURLPattern could confirm if the FIXMEs I added are actual bugs or the intended behaviour, and if someone with a mac could add the test also to the xcode. Then I'll focus on fixing the FIXMEs :-)