Bug 37922 - Lots of leaks of SVGFilterBuilder objects in RenderSVGResourceFilter
Summary: Lots of leaks of SVGFilterBuilder objects in RenderSVGResourceFilter
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Adam Roben (:aroben)
URL: http://build.webkit.org/results/SnowL...
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2010-04-21 07:11 PDT by Adam Roben (:aroben)
Modified: 2010-04-21 07:43 PDT (History)
0 users

See Also:


Attachments
Fix leaks of FilterData/SVGFilterBuilder in RenderSVGResourceFilter (1.59 KB, patch)
2010-04-21 07:40 PDT, Adam Roben (:aroben)
hyatt: review+
hyatt: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2010-04-21 07:11:47 PDT
The SnowLeopard leaks bot is showing lots of leaks of SVGFilterBuilder objects in RenderSVGResourceFilter.

I think the bug is in RenderSVGResourceFilter::applyResource, which allocates a FilterData (which holds an SVGFilterBuilder) on the heap, but doesn't destroy it when returning early under error conditions. Using an OwnPtr should fix this easily.
Comment 1 Adam Roben (:aroben) 2010-04-21 07:12:28 PDT
<rdar://problem/7888397>
Comment 2 Adam Roben (:aroben) 2010-04-21 07:40:42 PDT
Created attachment 53955 [details]
Fix leaks of FilterData/SVGFilterBuilder in RenderSVGResourceFilter
Comment 3 Dave Hyatt 2010-04-21 07:41:23 PDT
Comment on attachment 53955 [details]
Fix leaks of FilterData/SVGFilterBuilder in RenderSVGResourceFilter

r=me
Comment 4 Adam Roben (:aroben) 2010-04-21 07:43:07 PDT
Committed r57980: <http://trac.webkit.org/changeset/57980>