Bug 37918 – [GTK] Markup of copied non ASCII characters is broken

• Status: RESOLVED
• Resolution: FIXED
• Component: HTML Editing

[Shinichiro Hamaji]

Created attachment 53943 [details]
test case

How to reproduce:

- Open the attached HTML with GtkLauncher
- Select more than 4 UTF8 characters in the HTML and copy it
- Paste it after "paste here:"
- You should see a string shorter than the original text

This is the reason why editing/pasteboard/copy-backslash-with-euc.html is failing.

I'll post a patch soon later.

[Shinichiro Hamaji]

Created attachment 53944 [details]
Patch v1

[Shinichiro Hamaji]

(In reply to comment #1)
> Created an attachment (id=53944) [details]
> Patch v1

FYI, this document doesn't say gtk_selection_data_set() takes the number of UTF8 characters as the length of data.

http://library.gnome.org/devel/gtk/stable/gtk-Selections.html#gtk-selection-data-set

[Eric Seidel (no email)]

Comment on attachment 53944 [details]
Patch v1

It seems a comment in the code would be helpful here.

[Eric Seidel (no email)]

LGTM, I dont' need to see this again, even if you add a comment.  If you want to cq it with changes, you can always use "webkit-patch land-safely".

[Eric Seidel (no email)]

I'm not sure a comment is needed, but if you feel others might be confused by this API like the original author was, then please add one.

[Eric Seidel (no email)]

Attachment 53944 [details] was posted by a committer and has review+, assigning to Shinichiro Hamaji for commit.

[Shinichiro Hamaji]

It seemed this fix was done by this change: http://trac.webkit.org/changeset/58468

So, I'll just commit the change for the Skipped list.

[Shinichiro Hamaji]

Committed r58866: <http://trac.webkit.org/changeset/58866>