Bug 37915 - WebKit build failure with xhtmlmp enabled , after patches for Bug 37175
Summary: WebKit build failure with xhtmlmp enabled , after patches for Bug 37175
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Major
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-21 02:14 PDT by Charles Wei
Modified: 2010-04-21 19:42 PDT (History)
2 users (show)

See Also:


Attachments
This patch fixes the build problem caused by defect 37175 (only fails when xhtmlmp is enabled) (1.44 KB, patch)
2010-04-21 02:25 PDT, Charles Wei
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Charles Wei 2010-04-21 02:14:34 PDT
With bug 37175,  which factors out DocumentWriter from FrameLoader,  the API FrameLoader::responseMIMEType() is now DocumentWriter::mimeType().

#if ENABLE(XHTMLMP)
bool Document::isXHTMLMPDocument() const 
{
...
    return frame()->loader()->responseMIMEType() == "application/vnd.wap.xhtml+xml";
}
#endif 

should be changed to : 

   return frame()->loader()->writer()->mimeType() == "application/vnd.wap.xhtml+xml";
Comment 1 Charles Wei 2010-04-21 02:25:04 PDT
Created attachment 53933 [details]
This patch fixes the build problem caused by defect 37175 (only fails when xhtmlmp is enabled)

This patch fixes the build problem caused by defect 37175 (only fails when xhtmlmp is enabled)
Comment 2 WebKit Commit Bot 2010-04-21 19:42:00 PDT
Comment on attachment 53933 [details]
This patch fixes the build problem caused by defect 37175 (only fails when xhtmlmp is enabled)

Clearing flags on attachment: 53933

Committed r58041: <http://trac.webkit.org/changeset/58041>
Comment 3 WebKit Commit Bot 2010-04-21 19:42:04 PDT
All reviewed patches have been landed.  Closing bug.