Bug 37912 - [Qt] Build fix: warning on L933 of CompositeEditCommand.cpp
Summary: [Qt] Build fix: warning on L933 of CompositeEditCommand.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: All Linux
: P1 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-20 23:32 PDT by Ryosuke Niwa
Modified: 2010-07-13 04:59 PDT (History)
0 users

See Also:

Attachments
replaces the ternary operator by an if statement (2.48 KB, patch)
2010-04-20 23:36 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
added more comments and removed the changes in xcodeproj (2.04 KB, patch)
2010-04-20 23:45 PDT, Ryosuke Niwa 		eric: review+
Details | Formatted Diff | Diff
another repro (with automation) (577 bytes, text/html)
2010-07-13 04:53 PDT, Hajime Morrita 		no flags Details
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2010-04-20 23:32:12 PDT 
Qt Linux builds complains about the line 933 of CompositeEditCommand.cpp because it uses ternary operator to initialize RefPtr.
Comment 1 Ryosuke Niwa 2010-04-20 23:36:39 PDT 
Created attachment 53922 [details]
replaces the ternary operator by an if statement
Comment 2 Ryosuke Niwa 2010-04-20 23:45:39 PDT 
Created attachment 53923 [details]
added more comments and removed the changes in xcodeproj
Comment 3 Eric Seidel (no email) 2010-04-20 23:47:28 PDT 
Comment on attachment 53923 [details]
added more comments and removed the changes in xcodeproj

Fantastic!
Comment 4 Ryosuke Niwa 2010-04-21 01:10:41 PDT 
Comment on attachment 53923 [details]
added more comments and removed the changes in xcodeproj

Removed from the commit queue since this patch has already been committed.
Comment 5 Ryosuke Niwa 2010-04-21 01:11:40 PDT 
Landed in http://trac.webkit.org/changeset/57957.
Comment 6 Hajime Morrita 2010-07-13 04:53:16 PDT 
Created attachment 61356 [details]
another repro (with automation)
Comment 7 Hajime Morrita 2010-07-13 04:59:28 PDT 
Comment on attachment 61356 [details]
another repro (with automation)

Oops. posted to a wrong bug.