RESOLVED FIXED 37906
Remove JSC::UStringImpl; unify with StringImpl. 
https://bugs.webkit.org/show_bug.cgi?id=37906
Summary Remove JSC::UStringImpl; unify with StringImpl.
Gavin Barraclough
Reported 2010-04-20 18:52:07 PDT
JSC::UStringImpl and WebCore::StringImpl (soon to be renamed to WTF::StringImpl) are almost identical. Remove duplication of code by unifying the two, move missing features from UStringImpl into StringImpl & delete the class UStringImpl.
Attachments
The patch (49.73 KB, patch)
2010-04-20 18:54 PDT, Gavin Barraclough 		no flags
DetailsFormatted DiffDiff
The patch, without random whitespace change to WebCore.xcodeproj. (49.08 KB, patch)
2010-04-20 18:58 PDT, Gavin Barraclough 		oliver: review+
DetailsFormatted DiffDiff
#include <limits.h> instead of <limits> (1.57 KB, patch)
2010-04-21 11:02 PDT, Gavin Barraclough 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2010-04-20 18:54:38 PDT
Created attachment 53911 [details] The patch
Gavin Barraclough
Comment 2 2010-04-20 18:58:25 PDT
Created attachment 53912 [details] The patch, without random whitespace change to WebCore.xcodeproj. Not sure what xcode was thinking there!
Oliver Hunt
Comment 3 2010-04-20 19:04:11 PDT
Comment on attachment 53912 [details] The patch, without random whitespace change to WebCore.xcodeproj. r=me
Early Warning System Bot
Comment 4 2010-04-20 19:12:09 PDT
Attachment 53912 [details] did not build on qt: Build output: http://webkit-commit-queue.appspot.com/results/1829015
WebKit Review Bot
Comment 5 2010-04-20 19:31:02 PDT
Attachment 53911 [details] did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/1808012
Geoffrey Garen
Comment 6 2010-04-21 09:39:10 PDT
error: ‘UINT_MAX’ was not declared in this scope
Gavin Barraclough
Comment 7 2010-04-21 11:02:46 PDT
Created attachment 53971 [details] #include <limits.h> instead of <limits>
Darin Adler
Comment 8 2010-04-21 11:05:39 PDT
Comment on attachment 53971 [details] #include <limits.h> instead of <limits> Strange change log entry. This is a build fix, right?
Gavin Barraclough
Comment 9 2010-04-21 11:10:13 PDT
(In reply to comment #8) > (From update of attachment 53971 [details]) > Strange change log entry. This is a build fix, right? This is still the full patch, I didn't get this landed last night. (No change from the patch olliej reviewed, except the include change).
Gavin Barraclough
Comment 10 2010-04-21 13:43:00 PDT
fix in r58001
Note You need to log in before you can comment on or make changes to this bug.