Bug 37903 – Added missing #include "Lookup.h" in LUT source files.

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Patrick R. Gansterer]

I try to get WebKit built via CMake. When compiling the LUT source files (ArrayPrototype, DatePrototype, ...) I get an error because HashTableValue isn't defined.
Some simple includes fixed that problem.

[Patrick R. Gansterer]

Created attachment 53906 [details]
The patch

[Darin Adler]

Comment on attachment 53906 [details]
The patch

> Index: JavaScriptCore/runtime/ArrayPrototype.cpp
> ===================================================================
> --- JavaScriptCore/runtime/ArrayPrototype.cpp	(revision 57939)
> +++ JavaScriptCore/runtime/ArrayPrototype.cpp	(working copy)
> @@ -24,13 +24,13 @@
>  #include "config.h"
>  #include "ArrayPrototype.h"
>  
> -#include "CodeBlock.h"
>  #include "CachedCall.h"
> +#include "CodeBlock.h"
>  #include "Interpreter.h"
>  #include "JIT.h"
>  #include "JSStringBuilder.h"
> -#include "ObjectPrototype.h"
>  #include "Lookup.h"

Since ArrayPrototype.h already includes Lookup.h, I don't think ArrayPrototype.cpp needs to include it at all.

But this is not an argument against the patch. The reason this does not affect other builds is that most use AllInOneFile.cpp rather than compiling these files separately.

[WebKit Commit Bot]

Comment on attachment 53906 [details]
The patch

Clearing flags on attachment: 53906

Committed r57978: <http://trac.webkit.org/changeset/57978>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.