Bug 37903 - Added missing #include "Lookup.h" in LUT source files.
Summary: Added missing #include "Lookup.h" in LUT source files.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-20 17:01 PDT by Patrick R. Gansterer
Modified: 2010-04-21 07:10 PDT (History)
1 user (show)

See Also:


Attachments
The patch (4.43 KB, patch)
2010-04-20 17:01 PDT, Patrick R. Gansterer
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2010-04-20 17:01:06 PDT
I try to get WebKit built via CMake. When compiling the LUT source files (ArrayPrototype, DatePrototype, ...) I get an error because HashTableValue isn't defined.
Some simple includes fixed that problem.
Comment 1 Patrick R. Gansterer 2010-04-20 17:01:59 PDT
Created attachment 53906 [details]
The patch
Comment 2 Darin Adler 2010-04-20 17:15:02 PDT
Comment on attachment 53906 [details]
The patch

> Index: JavaScriptCore/runtime/ArrayPrototype.cpp
> ===================================================================
> --- JavaScriptCore/runtime/ArrayPrototype.cpp	(revision 57939)
> +++ JavaScriptCore/runtime/ArrayPrototype.cpp	(working copy)
> @@ -24,13 +24,13 @@
>  #include "config.h"
>  #include "ArrayPrototype.h"
>  
> -#include "CodeBlock.h"
>  #include "CachedCall.h"
> +#include "CodeBlock.h"
>  #include "Interpreter.h"
>  #include "JIT.h"
>  #include "JSStringBuilder.h"
> -#include "ObjectPrototype.h"
>  #include "Lookup.h"

Since ArrayPrototype.h already includes Lookup.h, I don't think ArrayPrototype.cpp needs to include it at all.

But this is not an argument against the patch. The reason this does not affect other builds is that most use AllInOneFile.cpp rather than compiling these files separately.
Comment 3 WebKit Commit Bot 2010-04-21 07:09:57 PDT
Comment on attachment 53906 [details]
The patch

Clearing flags on attachment: 53906

Committed r57978: <http://trac.webkit.org/changeset/57978>
Comment 4 WebKit Commit Bot 2010-04-21 07:10:01 PDT
All reviewed patches have been landed.  Closing bug.