Bug 37895 - Share common code from UStringImplBase with StringImpl
Summary: Share common code from UStringImplBase with StringImpl
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Gavin Barraclough
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-20 15:18 PDT by Gavin Barraclough
Modified: 2010-04-20 15:35 PDT (History)
0 users

See Also:

Attachments
The patch (40.76 KB, patch)
2010-04-20 15:19 PDT, Gavin Barraclough 		oliver: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2010-04-20 15:18:00 PDT 
The implementation of StringImpl & UStringImpl is very similar.  Restructure StringImpl to match UStringImpl, moving the flags and length into a base class, so that this can be shared between both string types to increase code reuse.
Comment 1 Gavin Barraclough 2010-04-20 15:19:49 PDT 
Created attachment 53893 [details]
The patch
Comment 2 Oliver Hunt 2010-04-20 15:30:28 PDT 
Comment on attachment 53893 [details]
The patch

r=me
Comment 3 Gavin Barraclough 2010-04-20 15:35:10 PDT 
Transmitting file data ..........
Committed revision 57932.