Bug 37887 - worker-close.html is flaky on slow machines.
Summary: worker-close.html is flaky on slow machines.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Dmitry Titov
URL:
Keywords:
Depends on: 37894
Blocks:
  Show dependency tree / graph
 
Reported: 2010-04-20 13:57 PDT by Dmitry Titov
Modified: 2010-04-20 16:08 PDT (History)
5 users (show)

See Also:

Attachments
Patch. (1.37 KB, patch)
2010-04-20 13:59 PDT, Dmitry Titov 		abarth: review+
dimich: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Titov 2010-04-20 13:57:23 PDT 
The test sends a message to the worker to close and also to reply with a message. Immediately, it sets up a timer for 500ms which will terminate the test. On slow machines, the timer may terminate test before the reply comes from the worker, so the actual dump is one message short. Fix is to start timer after the message comes. Patch coming.
Comment 1 Dmitry Titov 2010-04-20 13:59:39 PDT 
Created attachment 53877 [details]
Patch.
Comment 2 Adam Barth 2010-04-20 14:05:24 PDT 
Comment on attachment 53877 [details]
Patch.

Ok.  I'm sad that we have to setTimeout at all...
Comment 3 Dmitry Titov 2010-04-20 14:23:36 PDT 
Landed: http://trac.webkit.org/changeset/57916
Comment 4 WebKit Review Bot 2010-04-20 14:53:18 PDT 
http://trac.webkit.org/changeset/57919 might have broken SnowLeopard Intel Release (Tests)