37885 – backgroundColor is oddly indented in layer tree dump

Bug 37885 - backgroundColor is oddly indented in layer tree dump

Summary: backgroundColor is oddly indented in layer tree dump

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	Layout and Rendering (show other bugs)
Version:	528+ (Nightly build)
Hardware:	All OS X 10.5

Importance:	P2 Normal
Assignee:	Simon Fraser (smfr)

URL:
Keywords:

Depends on:
Blocks:

Reported:	2010-04-20 13:32 PDT by Simon Fraser (smfr)
Modified:	2010-04-20 22:42 PDT (History)
CC List:	4 users (show)

See Also:

Attachments
Patch (4.35 KB, patch) 2010-04-20 13:38 PDT, Simon Fraser (smfr)	andersca: review+	Details \| Formatted Diff \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Simon Fraser (smfr) 2010-04-20 13:32:51 PDT

In the layer tree dump obtained via layoutTestController.layerTreeAsText(), the backgroundColor property is weirdly indented:

       (backfaceVisibility visible)
            (backgroundColor none)
      (transform identity)

Comment 1 Simon Fraser (smfr) 2010-04-20 13:38:32 PDT

Created attachment 53875 [details]
Patch

Comment 2 Anders Carlsson 2010-04-20 13:39:14 PDT

Comment on attachment 53875 [details]
Patch

r=me

Comment 3 Simon Fraser (smfr) 2010-04-20 13:41:26 PDT

http://trac.webkit.org/changeset/57913

Comment 4 WebKit Review Bot 2010-04-20 16:08:19 PDT

http://trac.webkit.org/changeset/57913 might have broken Qt Windows 32-bit Debug
The following changes are on the blame list:
http://trac.webkit.org/changeset/57909
http://trac.webkit.org/changeset/57910
http://trac.webkit.org/changeset/57911
http://trac.webkit.org/changeset/57913
http://trac.webkit.org/changeset/57914
http://trac.webkit.org/changeset/57915
http://trac.webkit.org/changeset/57916
http://trac.webkit.org/changeset/57917
http://trac.webkit.org/changeset/57918

Comment 5 Eric Seidel 2010-04-20 22:42:15 PDT

I think this broke Snow Leopard.