Bug 37876 - [EFL] Update ChromeClientEfl and FrameLoaderClientEfl
: [EFL] Update ChromeClientEfl and FrameLoaderClientEfl
Status: RESOLVED FIXED
: WebKit
WebKit Misc.
: 528+ (Nightly build)
: PC Linux
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2010-04-20 11:32 PST by
Modified: 2010-04-22 10:57 PST (History)


Attachments
Update ChromeClientEfl.cpp to support the new ChromeClient API (8.94 KB, patch)
2010-04-20 11:33 PST, Leandro Pereira
no flags Review Patch | Details | Formatted Diff | Diff
Update ChromeClientEfl.cpp to support the new ChromeClient API (10.38 KB, patch)
2010-04-20 11:46 PST, Leandro Pereira
no flags Review Patch | Details | Formatted Diff | Diff
Update ChromeClientEfl and FrameLoaderclient to match recent WebCore API changes (10.60 KB, patch)
2010-04-22 10:43 PST, Leandro Pereira
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2010-04-20 11:32:30 PST
Attached patch updates ChromeClientEfl.{cpp,h} to conform to the new ChromeClient API, by fixing scroll() and implementing invalidate*() methods. Other methods were also implemented/stubbed as necessary (see ChangeLog entry for details).
------- Comment #1 From 2010-04-20 11:33:19 PST -------
Created an attachment (id=53855) [details]
Update ChromeClientEfl.cpp to support the new ChromeClient API
------- Comment #2 From 2010-04-20 11:35:51 PST -------
Attachment 53855 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp:367:  Declaration has space between type name and * in Eina_List *selected_filenames  [whitespace/declaration] [3]
WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp:367:  Use 0 instead of NULL.  [readability/null] [5]
WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp:368:  Declaration has space between type name and * in Eina_List *suggested_filenames  [whitespace/declaration] [3]
WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp:368:  Use 0 instead of NULL.  [readability/null] [5]
WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp:369:  Declaration has space between type name and * in void *filename  [whitespace/declaration] [3]
Total errors found: 5 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
------- Comment #3 From 2010-04-20 11:46:02 PST -------
Created an attachment (id=53859) [details]
Update ChromeClientEfl.cpp to support the new ChromeClient API

Iron out the style errors.
------- Comment #4 From 2010-04-22 10:29:43 PST -------
(From update of attachment 53859 [details])
Marking this one as obsolete as I'm submitting a newer patch soon.
------- Comment #5 From 2010-04-22 10:43:32 PST -------
Created an attachment (id=54072) [details]
Update ChromeClientEfl and FrameLoaderclient to match recent WebCore API changes

Attached patch also updates FrameLoaderClient to match recent WebCore API changes.
------- Comment #6 From 2010-04-22 10:48:11 PST -------
(From update of attachment 54072 [details])
OK!
------- Comment #7 From 2010-04-22 10:57:33 PST -------
(From update of attachment 54072 [details])
Clearing flags on attachment: 54072

Committed r58106: <http://trac.webkit.org/changeset/58106>
------- Comment #8 From 2010-04-22 10:57:39 PST -------
All reviewed patches have been landed.  Closing bug.